-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v3): remove deprecated interfaces #1424
Conversation
People can be co-author:
|
🦋 Changeset detectedLatest commit: 15d7c0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: -5.54 kB (-8.02%) ✅ Total Size: 63.5 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1424 +/- ##
==========================================
+ Coverage 77.21% 79.15% +1.93%
==========================================
Files 71 67 -4
Lines 597 566 -31
Branches 132 125 -7
==========================================
- Hits 461 448 -13
+ Misses 129 113 -16
+ Partials 7 5 -2
|
…uery Co-authored-by: Poco <[email protected]> Co-authored-by: Juhyeok Kang <[email protected]>
b208d26
to
15d7c0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify
"@suspensive/tsconfig": "workspace:*", | ||
"@suspensive/tsup": "workspace:*", | ||
"@tanstack/react-query": "catalog:react-query4", | ||
"@types/react": "catalog:react19", | ||
"react": "catalog:react19" | ||
}, | ||
"peerDependencies": { | ||
"@suspensive/react": "workspace:^2.18.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove peerDep
"@suspensive/tsconfig": "workspace:*", | ||
"@suspensive/tsup": "workspace:*", | ||
"@tanstack/react-query": "catalog:react-query5", | ||
"@types/react": "catalog:react19", | ||
"react": "catalog:react19" | ||
}, | ||
"peerDependencies": { | ||
"@suspensive/react": "workspace:^2.18.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove peerDep
"@suspensive/tsconfig": "workspace:*", | ||
"@suspensive/tsup": "workspace:*", | ||
"@types/react": "catalog:react19", | ||
"react": "catalog:react19" | ||
}, | ||
"peerDependencies": { | ||
"@suspensive/react": "workspace:^2.18.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove peerDep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
related #1349 #1325
Overview
PR Checklist