Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding PHP 8.4 images #308

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Adding PHP 8.4 images #308

merged 1 commit into from
Jan 8, 2025

Conversation

codyfinegan
Copy link
Member

No description provided.

@codyfinegan codyfinegan changed the title WIP: Adding PHP 8.4 images Adding PHP 8.4 images Jan 8, 2025
markmetcalfe
markmetcalfe requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@markmetcalfe markmetcalfe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to load a Totara site on MacOS with the php-8.4 and php-8.4-debug containers once the naming conflict is fixed 👍

compose/php.yml Outdated Show resolved Hide resolved
scq
scq approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@scq scq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested and working

markmetcalfe
markmetcalfe approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@markmetcalfe markmetcalfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again, works all good

@codyfinegan codyfinegan merged commit f47dd7d into develop Jan 8, 2025
@codyfinegan codyfinegan deleted the php84 branch January 8, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmetcalfe markmetcalfe markmetcalfe approved these changes

@scq scq scq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codyfinegan @scq @markmetcalfe