Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Coil-multiplatform and compose-multiplatform resources #217

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ dependencies {
implementation(libs.koin.core)
implementation(libs.koin.android)
implementation(libs.kotlinx.datetime)
implementation(libs.accompanist.coil)
implementation(libs.coil.compose)
implementation(libs.accompanist.navigationAnimation)
implementation(platform(libs.firebase.bom))
implementation(libs.firebase.analytics)
Expand Down
15 changes: 0 additions & 15 deletions android/src/main/res/drawable/baseline_sentiment_satisfied_24.xml

This file was deleted.

This file was deleted.

This file was deleted.

10 changes: 0 additions & 10 deletions android/src/main/res/drawable/ic_baseline_add_24.xml

This file was deleted.

11 changes: 0 additions & 11 deletions android/src/main/res/drawable/ic_baseline_arrow_back_24.xml

This file was deleted.

10 changes: 0 additions & 10 deletions android/src/main/res/drawable/ic_baseline_calendar_today_24.xml

This file was deleted.

10 changes: 0 additions & 10 deletions android/src/main/res/drawable/ic_baseline_check_24.xml

This file was deleted.

9 changes: 0 additions & 9 deletions android/src/main/res/drawable/ic_baseline_feedback_24.xml

This file was deleted.

10 changes: 0 additions & 10 deletions android/src/main/res/drawable/ic_baseline_person_24.xml

This file was deleted.

9 changes: 0 additions & 9 deletions android/src/main/res/drawable/ic_description_black_24dp.xml

This file was deleted.

9 changes: 0 additions & 9 deletions android/src/main/res/drawable/icon_company.xml

This file was deleted.

9 changes: 0 additions & 9 deletions android/src/main/res/drawable/icon_profile.xml

This file was deleted.

9 changes: 0 additions & 9 deletions android/src/main/res/drawable/icon_website.xml

This file was deleted.

9 changes: 0 additions & 9 deletions android/src/main/res/drawable/menu_info.xml

This file was deleted.

12 changes: 0 additions & 12 deletions android/src/main/res/drawable/menu_my_agenda.xml

This file was deleted.

9 changes: 0 additions & 9 deletions android/src/main/res/drawable/menu_schedule.xml

This file was deleted.

12 changes: 0 additions & 12 deletions android/src/main/res/drawable/menu_settings.xml

This file was deleted.

9 changes: 0 additions & 9 deletions android/src/main/res/drawable/menu_sponsor.xml

This file was deleted.

37 changes: 0 additions & 37 deletions android/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,43 +7,6 @@
<string name="notification_feedback_title">Feedback Time!</string>
<string name="notification_feedback_body">Your Feedback is Requested.</string>

<string name="schedule_title">Schedule</string>
<string name="droidcon_title">Droidcon London 2023</string>
<string name="schedule_session_detail_title">Session</string>
<string name="schedule_session_detail_status_future">This session hasn\'t started yet.</string>
<string name="schedule_session_detail_status_in_progress">This session is happening now.</string>
<string name="schedule_session_detail_status_past">This session has already ended.</string>
<string name="schedule_session_detail_status_conflict">This session conflicts with another session in your schedule.</string>
<string name="schedule_session_detail_is_attending_action_description">Do not attend</string>
<string name="schedule_session_detail_is_not_attending_action_description">Attend</string>
<string name="schedule_session_detail_info_description">Info</string>
<string name="schedule_session_detail_description_description">Description</string>
<string name="schedule_speaker_detail_title">Speaker</string>
<string name="schedule_speaker_detail_info_description">Info</string>
<string name="schedule_empty">There are no sessions planned.</string>
<string name="schedule_item_in_room">in %s</string>

<string name="my_agenda_title">My Agenda</string>
<string name="my_agenda_empty">You are not attending any sessions.</string>

<string name="sponsors_title">Sponsors</string>
<string name="sponsors_empty">Sponsors could not be loaded.</string>
<string name="sponsor_title">Sponsor</string>
<string name="sponsor_detail_description_description">Description</string>

<string name="settings_title">Settings</string>
<string name="settings_enable_feedback_title">Enable feedback</string>
<string name="settings_enable_reminders_title">Enable reminders</string>

<string name="feedback_title">What did you think of \"%s\"?</string>
<string name="feedback_opinion_placeholder">(Optional) Suggest improvements</string>
<string name="feedback_reaction_bad_description">Bad</string>
<string name="feedback_reaction_normal_description">Normal</string>
<string name="feedback_reaction_good_description">Good</string>
<string name="feedback_submit">Submit</string>
<string name="feedback_close_and_disable">Close and disable feedback</string>
<string name="feedback_skip">Skip feedback</string>

<string name="feedback_add_title">Add feedback</string>
<string name="feedback_change_title">Change your feedback</string>
</resources>
7 changes: 4 additions & 3 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ compileSdk = "34"

# Dependencies
kotlin = "1.9.22"
android-gradle-plugin = "8.2.1"
android-gradle-plugin = "8.2.2"
coroutines = "1.7.3"
kotlinx-datetime = "0.5.0"
ktor = "2.3.7"
Expand All @@ -30,7 +30,6 @@ compose-compiler = "1.5.8-dev-k1.9.22-42b6ec2b037"
composeNavigation = "2.7.6"
compose-jb = "1.6.0-dev1357"

accompanistCoil = "0.15.0"
accompanistNavigationAnimation = "0.32.0"
splashscreen = "1.0.1"
junit = "4.13.2"
Expand All @@ -46,13 +45,15 @@ android-desugaring = "2.0.4"
koin = "3.5.3"
uuid = "0.8.2"
ktlint = "11.0.0"
coil = "3.0.0-alpha02"

[libraries]
coil-compose = { module = "io.coil-kt.coil3:coil-compose", version.ref = "coil" }
coil-network = { module = "io.coil-kt.coil3:coil-network", version.ref = "coil" }
sqliter = { module = "co.touchlab:sqliter-driver", version.ref = "sqliter" }
compose-compiler = { module = "androidx.compose.compiler:compiler", version.ref = "compose-compiler" }
androidx-core-splashscreen = { module = "androidx.core:core-splashscreen", version.ref = "splashscreen" }

accompanist-coil = { module = "com.google.accompanist:accompanist-coil", version.ref = "accompanistCoil" }
accompanist-navigationAnimation = { module = "com.google.accompanist:accompanist-navigation-animation", version.ref = "accompanistNavigationAnimation" }
firebase-bom = { module = "com.google.firebase:firebase-bom", version.ref = "firebase-bom" }
firebase-analytics = { module = "com.google.firebase:firebase-analytics-ktx", version = "_" }
Expand Down
20 changes: 9 additions & 11 deletions ios/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,16 @@ kotlin {
optIn("kotlinx.coroutines.ExperimentalCoroutinesApi")
}
}
iosMain {
dependencies {
implementation(compose.ui)
implementation(compose.foundation)
implementation(compose.material)
implementation(compose.runtime)
iosMain.dependencies {
implementation(compose.ui)
implementation(compose.foundation)
implementation(compose.material)
implementation(compose.runtime)

api(project(":shared"))
api(project(":shared-ui"))
api(libs.kermit)
api(libs.kermit.simple)
}
api(project(":shared"))
api(project(":shared-ui"))
api(libs.kermit)
api(libs.kermit.simple)
}
}

Expand Down
Loading
Loading