Temporarily disable support for correct toString and hashCode because…

… it needs custom header generation.
touchlab · Apr 17, 2024 · c95a3f4 · c95a3f4
1 parent a24b677
commit c95a3f4
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/SKIE/acceptance-tests b/SKIE/acceptance-tests
diff --git a/...declaration/src/commonMain/kotlin/co/touchlab/skie/configuration/SkieConfigurationFlag.kt b/...declaration/src/commonMain/kotlin/co/touchlab/skie/configuration/SkieConfigurationFlag.kt
@@ -13,7 +13,6 @@ enum class SkieConfigurationFlag {
     Build_ConcurrentSkieCompilation,
 
     Migration_WildcardExport,
-    // TODO Add tests once we implement custom header generation
     Migration_AnyMethodsAsFunctions,
 
     Debug_VerifyDescriptorProviderConsistency,

diff --git a/...kgp_common/kotlin/co/touchlab/skie/phases/kir/CreateKirDescriptionAndHashPropertyPhase.kt b/...kgp_common/kotlin/co/touchlab/skie/phases/kir/CreateKirDescriptionAndHashPropertyPhase.kt
@@ -28,7 +28,10 @@ internal class CreateKirDescriptionAndHashPropertyPhase(
 
     context(KirPhase.Context)
     override fun isActive(): Boolean =
-        SkieConfigurationFlag.Migration_AnyMethodsAsFunctions.isDisabled
+        // WIP Change back once we generate custom header
+        // WIP Add tests for this flag and functionality
+        false
+//         SkieConfigurationFlag.Migration_AnyMethodsAsFunctions.isDisabled
 
     private val cache = mutableMapOf<FunctionDescriptor, KirProperty>()
 

diff --git a/...plugin/src/kgp_common/kotlin/co/touchlab/skie/phases/kir/CreateKirSimpleFunctionsPhase.kt b/...plugin/src/kgp_common/kotlin/co/touchlab/skie/phases/kir/CreateKirSimpleFunctionsPhase.kt
@@ -24,7 +24,9 @@ internal class CreateKirSimpleFunctionsPhase(
 
     private val convertedPropertyKindLazyInitializers = mutableListOf<() -> Unit>()
 
-    private val needsDescriptionAndHashFunctions = SkieConfigurationFlag.Migration_AnyMethodsAsFunctions in context.rootConfiguration.enabledFlags
+    // WIP Change back once we generate custom header
+//     private val needsDescriptionAndHashFunctions = SkieConfigurationFlag.Migration_AnyMethodsAsFunctions in context.rootConfiguration.enabledFlags
+    private val needsDescriptionAndHashFunctions = true
 
     context(KirCompilerPhase.Context)
     override suspend fun execute() {

diff --git a/...lugin/src/main/kotlin/co/touchlab/skie/plugin/configuration/SkieMigrationConfiguration.kt b/...lugin/src/main/kotlin/co/touchlab/skie/plugin/configuration/SkieMigrationConfiguration.kt
@@ -23,8 +23,7 @@ abstract class SkieMigrationConfiguration @Inject constructor(objects: ObjectFac
      * SKIE corrects this behavior and always exports `toString()` as `description` and `hashCode()` as `hash`.
      * To enable the original behavior, set this flag to `true`.
      */
-    // TODO Set this to false once we generate custom headers
-    val anyMethodsAsFunctions: Property<Boolean> = objects.property(Boolean::class.java).convention(true)
+    val anyMethodsAsFunctions: Property<Boolean> = objects.property(Boolean::class.java).convention(false)
 
     internal fun buildConfigurationFlags(): Set<SkieConfigurationFlag> =
         setOfNotNull(