[ext] Manifest V3 #1912
[ext] Manifest V3 #1912
Conversation
Since 1accca6 the backend adds a `Content-Security-Policy` header that overrides the `X-Frame-Options` header and allows frames from youtube. So this header change would only be needed for browser that do not support the `frame-ancestors` in `Content-Security-Policy`, so Chrome < 40 (2015) and Firefox < 58 (2018). I've tested on both Firefox and Chrome and the frame is indeed allowed if the header change is removed.
The commands `yarn configure`, `yarn configure:dev`, and `build.sh` still generate the manifest V2 version that is supported by Firefox and Chrome.
|
Thank you again @sigmike for all your contributions 👏 The current way Firefox handles the host permissions is indeed quite complex and I'm worried about the UX. I hope it will change in the future (see a related "bug"). To use the manifest v3 version on Firefox, I had to manually enable the permissions for each host from the extension menu, 3 clicks + 1 click per host 😵💫 (see the image below). For our extension to work, those host permissions are required, but it looks like they are optional for Firefox. If for specific reasons we want to publish a manifest v3 version for Firefox in the future, we may need to add an onboarding UI inviting the users to accept the permissions. On Chromium, the host permissions were accepted by default. Let's not forget to update our GitHub workflow before the end of manifest v2 to build both the Firefox and the Chromium version.
|
…TENSION_BROWSER set
related issues #1883
Description
This PR implements the changes to support manifest V3. The configure and build commands still produce a manifest V2.
You can produce a manifest V3 version for Chrome with:
And for Firefox:
For Firefox it defaults to manifest V2 because of UX and CORS issues, see #1883 (comment).
If we want to release a manifest V3 version for Chrome the remaining task is to update the build scripts, and we may also want to change the
yarn configurecommands.Checklist