update to latest black #833
Conversation
| @@ -81,7 +79,7 @@ def test_path_parts(self, input, expected): | |||
| def test_on_py_path(self): | |||
| cwd_parts = _path_parts(py.path.local()) | |||
| folder_parts = _path_parts(py.path.local("a/b/c")) | |||
| assert folder_parts[len(cwd_parts):] == ["a", "b", "c"] | |||
| assert folder_parts[len(cwd_parts) :] == ["a", "b", "c"] | |||
There was a problem hiding this comment.
PyCQA/pycodestyle#373 - black is right it seems
There was a problem hiding this comment.
Just my thoughts about this seem strange at first (like many other black style formats) but it does make sense once you look into it more in depth.
There was a problem hiding this comment.
Taken from the author here:
Colons in slices are implemented to the letter of PEP 8. Your disagreement here probably stems from pycodestyle mistakenly enforcing a different rule (no spaces before colons on if-statements, defs, and so on) in the slice context.
The relevant PEP 008 section says:
However, in a slice the colon acts like a binary operator, and should have equal amounts on either side (treating it as the operator with the lowest priority). In an extended slice, both colons must have the same amount of spacing applied. Exception: when a slice parameter is omitted, the space is omitted.
I don't particularly agree with the enforced style, but the interpretation does seem to fit within the bounds of PEP 008.
There was a problem hiding this comment.
@rpkilby, if you look at the "Yes"/"No" examples below this section, you will see function calls explicitly using a space separating the colon.
There was a problem hiding this comment.
@ambv the examples use a space, but it doesn't seem to be a part of the recommendation. At least, that's not how the text reads to me.
Regardless, the style black enforces is compliant, I just don't happen to like that particular choice. But again, that's just my irrelevant preference.
There was a problem hiding this comment.
Thanks! I agree that this is what PEP8 describes and I have succesfully been unaware of it for at least a decade, although I have red PEP8 many times. Another big 👍 for @ambv for being the perfectionist he is and getting stuff like this down to the last little detail.
| @@ -87,6 +87,7 @@ commands = python -m pip list --format=columns | |||
| [flake8] | |||
| max-complexity = 22 | |||
| max-line-length = 99 | |||
| ignore = E203, W503 | |||
There was a problem hiding this comment.
is PEP8 starting to disagree with black?
There was a problem hiding this comment.
I tend to believe you here :)
👍 more checks and formats