Skip to content

Commit

Permalink
Remove TODO in pkg/globalnet/controllers/ingress_pod_controller.go
Browse files Browse the repository at this point in the history
Issue submariner-io#3106
has been created to track this instead.

Signed-off-by: Tom Pantelis <[email protected]>
  • Loading branch information
tpantelis committed Jul 26, 2024
1 parent 172dacf commit c11f88c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/globalnet/controllers/ingress_pod_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ func (c *ingressPodController) process(from runtime.Object, _ int, op syncer.Ope
return ingressIP, false
}

// TODO: handle phase and podIP changes?
if c.ingressIPMap.Has(ingressIP.Name) || pod.Status.PodIP == "" ||
(!c.publishNotReadyAddresses && pod.Status.Phase != corev1.PodRunning) {
// Avoid assigning ingressIPs to pods that are not ready with an endpoint IP
Expand Down

0 comments on commit c11f88c

Please sign in to comment.