Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release Flags for Windows build. #103

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

sushshring
Copy link
Contributor

The current Release build configuration for Windows generates a MultiThreadedDebugDll. This uses the Debug heap on Windows. When paired with the Release versions of the TSS libraries, there are memory errors since the Release TSS library uses a non-debug heap, and the TPM2-Openssl DLL tries to free from the Debug heap. This change fixes that issue and brings it in line with the TSS library DLLs.

Signed-off-by: Sushrut Shringarputale <[email protected]>
@sushshring
Copy link
Contributor Author

@gotthardp CI failure but seems to be an infra failure. Can you investigate?

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be35c35) 78.17% compared to head (0fb43b0) 78.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files          17       17           
  Lines        2667     2667           
=======================================
  Hits         2085     2085           
  Misses        582      582           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gotthardp gotthardp merged commit 6ce1b76 into tpm2-software:master Oct 6, 2024
8 of 9 checks passed
@gotthardp
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants