Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [O, ]O and cO map groups to change all windows #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 10, 2014

I found this quite handy for a while already.

If it gets accepted, documentation should be added, of course.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 2, 2015

I've amended the initial commit (ca1411c), and rebased it on master.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 2, 2015

@tpope
Do you like the idea?
It allows for cOn to toggle line numbers in all windows at once.

@tpope
Copy link
Owner

tpope commented Jun 2, 2015

It's not a bad idea. Outside of 'number' I am not sure it will get much use. And I really hate going down the windo rabbit hole. (You're a first hand witness to all the trouble it has given me on fugitive.vim.)

How hard would it be to make the toggle variant put all windows into the same state? Having it toggle on some and off some seems pretty useless.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 2, 2015

I really hate going down the windo rabbit hole

Yeah, that's unfortunate, but manageable.

How hard would it be to make the toggle variant put all windows into the same state? Having it toggle on some and off some seems pretty useless.

It uses the same state for all windows, based on the current window.
Probably because the C-R>=<SID>toggle() is evaluated before the windo.

@tpope
Copy link
Owner

tpope commented Jun 2, 2015

What's your stance on the usefulness for other options? cOn is a bit awkward to type, so I'm wondering if we fudge things a bit and just always windo for 'number' and possibly 'relativenumber'.

@tpope
Copy link
Owner

tpope commented Jun 2, 2015

We're probably going to need special casing anyways, as :set number in :help is almost never what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants