More performance improvements by hiding expensive imports until they are needed #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Relates to: bridgecrewio#6740
Description
In the same spirit of bridgecrewio#6740 and #1, this pull request tries to gain even more performance improvements using a similar approach of hiding expensive imports until they are needed.
While similar, the approach here is more generic and doesn't just tackle the effect of importing all runners and checks. It instead tackles the problem of eagerly importing expensive packages even when they will never be used in a given invocation. As a result, the effect can be large even when running all checks against a directory.
When comparing against the
main
branch, we see performance improvements of up to -71% when running simple commands likecheckov --version
but still significant improvements of around -24% when running all checkov checks (e.g.checkov -d .
).Please refer to the issue and PR mentioned above for more details on motivation and methodology.
Benchmark results
Comparing against the
main
branch--version
--list
--framework=openapi
-d tests/openapi/
--framework=ansible
-d tests/ansible/examples/
--framework=terraform
-d tests/terraform/checks/data
-d tests/
Comparing against #1
--version
--list
--framework=openapi
-d tests/openapi/
--framework=ansible
-d tests/ansible/examples/
--framework=terraform
-d tests/terraform/checks/data
-d tests/
Checklist: