Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla hands rework #449

Merged
merged 18 commits into from
May 18, 2024
Merged

Vanilla hands rework #449

merged 18 commits into from
May 18, 2024

Conversation

tr7zw
Copy link
Owner

@tr7zw tr7zw commented May 18, 2024

No description provided.

@tr7zw tr7zw merged commit c9e7336 into main May 18, 2024
0 of 2 checks passed
Copy link

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

what-the-diff bot commented May 18, 2024

PR Summary

  • Updated First Person Settings
    In FirstPersonSettings.java, the representation of vanillaHands has been changed from a single boolean to a more expressive enum called VanillaHands. This change allows for easier interpretation of the vanillaHands settings. An additional feature, referred to as dynamicMode, has also been introduced as a boolean value.

  • Added VanillaHands class
    A new file VanillaHands.java has been introduced into the dev.tr7zw.firstperson.versionless.config package to support the updated vanillaHands setting.

  • Reworked LogicHandler operations
    The LogicHandler.java file has seen significant updates. Several new methods have been added, all aimed at tidy handling of first and third person views along with their related settings. These methods work together to replace previously bulky and complex conditions in methods for hiding hands and controlling dynamic hand behavior.

  • Refined ConfigScreen settings
    The ConfigScreenProvider.java now handles an updated vanillaHandsMode field instead of the earlier vanillaHands field. It has also been equipped to handle the new dynamicMode.

  • Adjusted Rendering Mixins
    The mix-in files for ArmorFeature, HeldItemFeature, HeldItemRenderer, and LivingEntityRenderer have all been updated with conditions to better manage the rendering of arms and items. This is based on the newly added methods in LogicHandler.

  • Enhanced Player Mixin
    In PlayerMixin.java, a key method call was swapped from getLogicHandler().showVanillaHands to getLogicHandler().hideArmsAndItems, indicative of new functionality.

  • Localization Updates
    The localization files en_us.json and ru_ru.json have been updated with new textual options and tooltips for vanillaHands and dynamicHands, to reflect new settings functionality.

Jonah-Hansen added a commit to chocolate-edition/Chocolate-Edition that referenced this pull request Jan 7, 2025
changelog:
- All the versions by @tr7zw in tr7zw/FirstPersonModel#410
- Added map_atlases:atlas to auto vanilla hands
- Hiding the cape while swimming, so it can't clip into the camera
- Added NeoForge support
- Fix mod compatibility issues where crouching doesn't apply the offset
- Fix cases where vanilla hands still rendering the held inworld item(for example Create or MrCrayfish's Gun mod)
- Better hiding of stuff attached to the body while swimming and arms with vanilla hands
- All fixes/changes/additions from 1.20 versions are now in all versions, back to 1.16.5
- Add compatibility for Create mod by @XSentinelu in tr7zw/FirstPersonModel#393
- Add Mod Menu entry and create ru_ru.json by @XSentinelu in tr7zw/FirstPersonModel#401
- Fix the torso vanishing while swimming, even in f5
- Better compatibility for detecting sneaking
- Lots of code cleanup
- Can confirm that the latest version of Custom Player Models now works again with this mod
- Located the exact issue on why pehkui causes issues, will be addressed next release
- Add another workaround for helmets rendering when they shouldn't(fixes issues with some helmets and Better Combat)
- Add config to auto toggle the mod on certain items(by default right now the Exposure mod camera)
- Add FastAnim to the breaks list(causes lots of rendering issues by skipping stuff)
- Add workaround for Better Combat crashing, until it's updated
- Fix the armor bar flashing in singleplayer while wearing a helmet
- Fix sneaking having no offset when using Pehkui(For now no auto-scaling the offset when the size changes)
- Rework hiding logic. Might help with some mods/spectating entities, please report any issues
- Fix vanilla hands/auto vanilla hands being inconsistent and hiding the chestplate
- Fix auto vanilla hands hiding the entire armor
- Vanilla Hand Items & Dynamic Hands by @YoungSoulluoS in tr7zw/FirstPersonModel#437
- Adds a new "Dynamic" option, which will seamlessly auto-switch between the vanilla view and firstperson view, depending on the view angle. It's really cool, thanks for the contribution
- Vanilla hands rework by @tr7zw in tr7zw/FirstPersonModel#449
- To better support the new Dynamic option, rewrote the entire Vanilla Hands logic to make more sense, have fewer bugs, be more logical to work with, and use
- Fix dynamicMode applying even when vanilla hands is turned off
- Change how unhiding bodyparts works, should fix issues of broken arms/heads
- Don't render a second player when sleeping
- Fix weird sitting rotations on modded chairs and some entities
- Fix Elytra clipping into the camera on landing for 1 tick
- Add Freecam support for Forge/NeoForge(Fabric already had support)
- Fix link the mod menu
- Hotfix: Fix that the torso stays hidden after swimming
- Updated pt_br.json and pt_pt.json file to match recent versions by @Landrozaum in tr7zw/FirstPersonModel#473
- Fix keybind modname translation key
- Fix shadow rendering being glitchy on block edges in 1.16.5-1.21.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants