Fix errors when attachment name contains non-ASCII characters #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebDieBln
force-pushed
the
AttachmentNameUtf8
branch
2 times, most recently
from
24e4a16
to
5289bc3
Compare
|
@SebDieBln Let me know if you are interested in having commit access. |
SebDieBln
force-pushed
the
AttachmentNameUtf8
branch
from
5289bc3
to
43d926e
Compare
|
@rjollos It has been a while but I finally found the time to work on this project again (preparing to upgrade our Trac vom 1.0.9 to 1.4.x). And yes, I feel honoured and would appreciate commit access! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a file whose name contains non-ASCII characters, errors where shown when
This was due to the name being processed as an ASCII string and is fixed by this PR.