ENH Update status flags generally, not just for SiteTree #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
GuySartorelli
commented
Nov 20, 2024
| * | ||
| * @param array $flags | ||
| */ | ||
| protected function updateStatusFlags(&$flags) |
There was a problem hiding this comment.
Nothing here is specific to SiteTree anymore. This is now split up between FluentExtension and FluentVersionedExtension along with the methods called from here.
GuySartorelli
commented
Nov 20, 2024
| /** | ||
| * Update status flags based on whether the current record is exists in the current locale. | ||
| */ | ||
| protected function updateStatusFlags(array &$flags): void |
There was a problem hiding this comment.
See FluentSiteTreeExtension for where this code originated.
GuySartorelli
commented
Nov 20, 2024
| * | ||
| * @param array $flags | ||
| */ | ||
| protected function updateStatusFlags(array &$flags): void |
There was a problem hiding this comment.
See FluentSiteTreeExtension for where this code originated.
GuySartorelli
commented
Nov 20, 2024
| * @param DBField|null $badgeField | ||
| * @see VersionedGridFieldItemRequest::Breadcrumbs() | ||
| */ | ||
| protected function updateBadge(&$badgeField) |
There was a problem hiding this comment.
That hook doesn't exist anymore - this is now handled through generalised status flag rendering in core.
GuySartorelli
commented
Nov 20, 2024
| * @param ArrayList $breadcrumbs | ||
| * @see CMSMain::Breadcrumbs() | ||
| */ | ||
| protected function updateBreadcrumbs(ArrayList $breadcrumbs) |
There was a problem hiding this comment.
This is now handled through generalised status flag rendering in core.
emteknetnz
requested changes
Nov 26, 2024
GuySartorelli
force-pushed
the
pulls/8/status-flags
branch
from
fc40b0a to
0113c90
Compare
|
Updated status flag tests and added a little more coverage than was already there. |
emteknetnz
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
silverstripe/silverstripe-framework#11460 makes the
updateStatusFlags()extension hook available for all models. In combination with other PRs linked in the below issue, status flag rendering has now been standardised.This PR updates fluent to add fluent status flags to any fluent model, not just
SiteTree, and removes custom code that renders flags in places likeLeftAndMainbreadcrumbs, gridfield edit form breadcrumbs, and gridfield rows. Those are all handled in core now.Please note that this PR relies on silverstripe/silverstripe-framework#11460 along with others.
Please do not merge this PR until all dependent PRs have been merged.
Looks like this in CMSMain:
Looks like this in gridfield (yes that is a gridfield holding pages, no it is not CMSMain):
Issue
SiteTreeinCMSMainsilverstripe/silverstripe-cms#2947