-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pane primitives #1660
add pane primitives #1660
Conversation
size-limit report 📦
|
and add a CI check
Extract watermark into plugin
Screen.Recording.2024-08-08.at.13.28.12.movwhen I'm attaching the watermark
and then resize the pane, the watermark stay at the same position and if I make a pane small enough watermark is not visible completely. |
Yeah, that makes sense that is broken. The code is written to do the positioning calculations on the view (assuming there is only one pane). I need to move that placement position logic into the renderer (which has access to the actual pane canvas dimensions). The plugin was written before we had multiple pane support and this wasn't considered. I'll fix this. Thanks for spotting it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. great job and really nice improvement for plugins capabilities 🚀
@SlicedSilver one minor thing, could you pls check the failing |
@illetid |
Type of PR: enhancement
Update: INCLUDES the Watermark Plugin changes as well.
PR checklist:
Overview of change:
Adds Pane Primitives which are attached to a pane instead of requiring a series.
To do