Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies to work with node 14 and for the tests to pass #9

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

martinheidegger
Copy link

  • node_modules/scrypt can not be compiled with Node 14
  • ethereumjs-testrpc is deprecated in favor of ganache
  • forever is not node 14 compatible (used when testing the engine)
  • Several tests fail with timeout -> Increased timeout
  • Ethereum test hangs at fdd5cb365db5571a6ef6ea098f329b8b3d8bab0a during the e2e tests:
    • "watch txId"
    • "sender seals"
    • "receiver seals"
    • "delete watch after X confirmed"
    • "object publish status"
    • "versioning can only be done by previous author"
    • "send sealed"
  • Ethereum test error at x during sealwatch tests:
    • "watch":
      expected: |-
      { newwatch: true, readseal: true }
      actual: |-
      { newwatch: true }
      at: Timeout._onTimeout (/tradle/engine/test/sealwatch.test.js:112:7)
      
    • "batch": batch timed out after 100000ms
  • Missing dependency updates:
    • "bl" as dependency of old levelup
    • "elliptic" as deep depdenency of web3
    • "underscore" as deep dependency of web3
    • "socket.io-parser" as deep dependency of sendy
    • "lodash" as deep dependency of ganche-core
    • "node-fetch" as deep dependency of web3

require statements can be defined using circular dependencies, typescript types and humans have problems with this. this commit makes sure we use a normal dependency tree without back references.
By compiling the schema ahead of time (as recommended in the documentation of protocol-buffers) the startup time should be reduced and the performance enhanced at the same time.
This will make execution faster as the assert operation doesn’t try to jit compile. Furthermore all checks are typed now.
…ng anything

The more changes come to the code the more of a problem the obsolete code becomes as it is impossible to say if it could ever be reinstated to working code.
…r on that - also, it is better to move to ts/esm at a later point
by using the dynamic syntax, code completion doesn't work as well and it is more difficult to turn into typescript code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant