Add android progress callback #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbycrosz
force-pushed
the
add-android-progress-callback
branch
2 times, most recently
from
990b40e
to
5fa08df
Compare
sbycrosz
force-pushed
the
add-android-progress-callback
branch
from
5fa08df
to
df47681
Compare
sbycrosz
force-pushed
the
add-android-progress-callback
branch
from
3b1fee6
to
3afce8c
Compare
mvayngrib
reviewed
Jun 8, 2021
mvayngrib
reviewed
Jun 8, 2021
mvayngrib
reviewed
Jun 8, 2021
|
thanks for the PR @sbycrosz ! I'm unable to test this so I'm going to rely on you to do it after we're done here, is that ok? 😛 |
|
Okay, seems to be working fine on my project 👍 But this library does need an example project hahaha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added a progress callback to the scan function for better scanning UX 🎉
Pretty much copy-pasted from this commit
Cheers,
Sam