Apply suggestions from code review

Co-authored-by: Rémi BUISSON <[email protected]>
traefik · Dec 5, 2023 · a878217 · a878217
1 parent 630f47b
commit a878217
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/traefik-hub/templates/deployment.yaml b/traefik-hub/templates/deployment.yaml
@@ -93,7 +93,7 @@ spec:
             {{- with .kubernetesCRD.namespaces }}
             - --providers.kubernetescrd.namespaces="{{ . }}"
             {{- end }}
-            {{- with .kubernetesCRD.labelselector }}
+            {{- with .kubernetesCRD.labelSelector }}
             - --providers.kubernetescrd.labelselector="{{ . }}"
             {{- end }}
             {{- with .kubernetesCRD.throttleDuration }}
@@ -111,7 +111,7 @@ spec:
             {{- with .kubernetesIngress.namespaces }}
             - --providers.kubernetesingress.namespaces="{{ . }}"
             {{- end }}
-            {{- with .kubernetesIngress.labelselector }}
+            {{- with .kubernetesIngress.labelSelector }}
             - --providers.kubernetesingress.labelselector="{{ . }}"
             {{- end }}
             {{- with .kubernetesIngress.ingressClass }}

diff --git a/traefik-hub/tests/deployment_test.yaml b/traefik-hub/tests/deployment_test.yaml
@@ -168,15 +168,15 @@ tests:
           token: "xxx"
           certAuthFilePath: "/var/crds.pem"
           namespaces: "ns1,ns2"
-          labelselector: "foo=bar"
+          labelSelector: "foo=bar"
           ingressClass: "crd"
           throttleDuration: "10s"
         kubernetesIngress:
           endpoint: "local2.tld"
           token: "yyy"
           certAuthFilePath: "/var/ings.pem"
           namespaces: "ns3,ns4"
-          labelselector: "bar=foo"
+          labelSelector: "bar=foo"
           ingressClass: "ing"
           ingressEndpoint:
             hostname: "ing.tld"

diff --git a/traefik-hub/values.yaml b/traefik-hub/values.yaml
@@ -77,15 +77,15 @@ providers:
     token:
     certAuthFilePath:
     namespaces:
-    labelselector:
+    labelSelector:
     ingressClass:
     throttleDuration:
   kubernetesIngress:
     endpoint:
     token:
     certAuthFilePath:
     namespaces:
-    labelselector:
+    labelSelector:
     ingressClass:
     ingressEndpoint:
       hostname: