fix: use cluster name in label selector of service controller

[NEwa-05]

What does this PR do?

Patch controller service creation to add cluster name as label (already done for Registry service and Proxy service)

Motivation

When deploying 2 separate instances of Traefikee, the controller is messing up its configuration.

More

• Yes, I updated the tests accordingly
• Yes, I ran make test and all the tests passed

[mloiseleur]

@NEwa-05 🤔 Why the " Yes, I updated the tests accordingly" is checked and there is no test. I'm wondering 😅. Anyway, I suggest to add a test on this in order to ensure it won't disappear with time.

[NEwa-05]

Oups, I did work on another test/PR and checked the update box for this, my bad.

If we do that for this service we need to do it as well for the registry and proxy as well then.
Why not, it makes sense, I'll update the PR with the test for both services.

[NEwa-05]

Tests has been added for both services.

[mloiseleur]

See my comments. Otherwise, it looks good !

[mloiseleur]

@NEwa-05 I tried to improve the title. Feel free to update it if I missed something. Also, you should test the upgrade, on a Deployment it's a breaking change to update label selector : it's an immutable field. On Service, maybe not.

[NEwa-05]

I have installed a new deployment and upgraded a new deployment without issues.

I do see the point of the breaking change, but unless the controller pod where not labeled with the cluster name in older helm deployment there will be no change for the service and pod mapping.

For me, it's more a fix than a change since both proxies and registry were already using cluster name within the service label selector, WDYT

[darkweaver87]

LGTM