Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n new LWC (AR+EG) #958

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

i18n new LWC (AR+EG) #958

wants to merge 5 commits into from

Conversation

egraells
Copy link

What does this PR do?

Add localization recipe

What issues does this PR fix or reference?

#

The PR fulfills these requirements:

[ ] Tests for the proposed changes have been added/updated.
[ ] Code linting and formatting was performed.

Functionality Before

<insert gif and/or summary>

Functionality After

<insert gif and/or summary>

@egraells egraells requested a review from a team as a code owner June 27, 2024 17:45
Copy link
Contributor

@satyasekharcvb satyasekharcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space after colon for the better readability and grammatically correct (maybe we can use nbsp). Rest, it looks good.

<lightning-card title="MiscI18n" icon-name="custom:custom19">
<div class="slds-var-m-around_medium">
<p>
User's locale:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space after colon for the better readability and grammatically correct (maybe we can use nbsp)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Satya for your review, I will add the spaces and let you know.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made, please let me know.

<span class="userLocale"><b>{userLocale}</b></span>
</p>
<p>
Today's date formatted with {userLocale}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space after colon for the better readability

</span>
</p>
<p>
100 {userCurrency} formatted with {userLocale}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space after colon for the better readability

</span>
</p>
<p>
Today's date formatted with {japanLocale}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space after colon for the better readability

</span>
</p>
<p>
100 {japanCurrency} formatted with {japanLocale}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space after colon for the better readability

Copy link
Contributor

@satyasekharcvb satyasekharcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use &nbsp; instead of space as HTML collapses whitespaces by default. Same for other spaces as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants