-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slottify expressions #1729
base: master
Are you sure you want to change the base?
Slottify expressions #1729
Conversation
Fixes some issues in the examples directory that can be found by running mypy as follows: mypy --check-untyped-defs examples/**/*.py
* Black formatting * Native tests pass * Passes checked in (non-generated) wasm tests * Some ethereum test fixes * Reenable wasm tests * Fix mypy error * Use pytest timeout * mypy checked untyped defs in manticore.core.smtlib
raise ExpressionError( | ||
"You tried to use a Bool Expression as a boolean constant. Expressions could represent a set of concrete values." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement is causing issues. I've replaced it with just
raise ExpressionError( | |
"You tried to use a Bool Expression as a boolean constant. Expressions could represent a set of concrete values." | |
) | |
return self |
and it seems to be passing for me natively on both Python 3.6 and 3.9 🤷
Maybe we should revert this to how it was.
6d3d72c
to
a81f8e8
Compare
__xslots__: Tuple[str, ...] = ( | ||
"_written#v", | ||
"_concrete_cache#v", | ||
"_length#v", | ||
"_default#v", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the #v
suffix mean here?
__slots__
from parent classes automatically-ish. (xslots)__subclasses__
to ensure all are accounted for..... (tbc)