Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heap Tracker #1805

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Heap Tracker #1805

wants to merge 19 commits into from

Conversation

sschriner
Copy link
Contributor

No description provided.

@sschriner sschriner requested a review from ekilmer September 25, 2020 18:34
@sschriner sschriner self-assigned this Sep 25, 2020
ekilmer
ekilmer reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some tests are added, I'll review it a bit more. Looking good so far!

I made a few comments on the use of specific register names, which is fine for now, but we should either try to disallow inclusion of this functionality for anything except x86-64 or make the registers more generic to work on the supported architectures

manticore/native/heap_tracking/hook_malloc_library.py Outdated Show resolved Hide resolved
manticore/native/heap_tracking/hook_malloc_library.py Outdated Show resolved Hide resolved
manticore/native/heap_tracking/hook_malloc_library.py Outdated Show resolved Hide resolved
@sschriner sschriner marked this pull request as ready for review February 3, 2021 18:47
@sschriner sschriner marked this pull request as draft February 3, 2021 18:47
ekilmer
ekilmer reviewed Feb 23, 2021
View reviewed changes
Copy link
Contributor

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few comments

manticore/native/heap_tracking/malloc_lib_data.py Outdated Show resolved Hide resolved
manticore/native/heap_tracking/hook_malloc_library.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekilmer ekilmer ekilmer left review comments

@pgoodman pgoodman pgoodman left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@sschriner sschriner

Labels
CHESS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sschriner @pgoodman @ekilmer