Better control of gas accounting #1823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehennenfent
reviewed
Dec 15, 2020
| default="static", | ||
| description=( | ||
| "Control how to keep the gas count" | ||
| "insane: Keep static and dynamic gas including transaction fee VERY EXPENSIVE (INSANE)." |
There was a problem hiding this comment.
Nit, but can we make this "exhaustive"? Or, if you want to preserve the suggestion that it's over-the-top, perhaps "ludicrous"?
| available_gas = self._gas | ||
| available_gas -= fee | ||
|
|
||
| exception = Operators.OR( | ||
| Operators.UGT(fee, self._gas), | ||
| Operators.ULT(self.safe_mul(available_gas, 63), available_gas), | ||
| ) | ||
| self.fail_if(exception) |
There was a problem hiding this comment.
Does this line need to check the value of consts.gas before deciding to raise the exception?
|
@feliam were you still hoping to merge this? I think those couple of nits are the only things blocking it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add evm.gas configuration constant/variable/thing to control how to account gas. For example "static" will ignore all dynamic calculated fees. (This is different from evm.oog. The latter controls how and when to check for Out Of Gas)
Change rpl -> rust-rpl dependency.