Add optional config to api, to make hmvc easier. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YaManicKill why can't you put this stuff inside the normal |
|
Well, you can. But the idea of hmvc is that you put everything relating to a feature (or just part of the code). I think that routes and policies are quite important to that, and it would be really nice to define them in the feature folders. |
|
👍 agree with @YaManicKill hmvc need to have all it's related to the same feature in one folders. That include policies and routes. For big projects that can prevent to have big |
tjwebb
added a commit
that referenced
this pull request
Jan 7, 2016
Add optional config to api, to make hmvc easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in trailsjs/generator-trails#12, this allows us to move specific config values into the api model, which would make hmvc easier (as we can store routes, policy config etc) in feature folders.