Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Viaplay profile usage #369

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

lindvall
Copy link
Contributor

@lindvall lindvall commented Feb 8, 2024

Fixes #155

I've implemented support for Viaplay profiles.

Currently it requires clearing caches after changing profile in Viaplay in order to remove the history of the previously selected profile. Any suggestions are welcome, or simply leave it as is.

@lindvall lindvall changed the title Fix Viaplay profile usage (#155) Fix Viaplay profile usage Feb 12, 2024
Copy link
Member

@MrMamen MrMamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly worried that this may break some regions. The profile change is allerede a known bug #347

src/services/viaplay/ViaplayApi.ts Show resolved Hide resolved
@lindvall
Copy link
Contributor Author

lindvall commented Feb 19, 2024

Thanks for the approval and the pointer to the catching issue while changing profile! Seems like a rather low priority bug (as you normally only use/sync your own profile).

Hopefully I can solve solve some other issues, and/or implement suggestions in the future.

@lindvall lindvall closed this Feb 19, 2024
@lindvall lindvall reopened this Feb 19, 2024
@MrMamen MrMamen merged commit cd8fbed into trakt-tools:master Feb 19, 2024
2 checks passed
@lindvall lindvall deleted the viaplay_use_profiles branch February 19, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viaplay - Wrong profile
2 participants