Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(episode): define reusable episode atoms to prepare for up-next #22

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

vladjerca
Copy link
Collaborator

@vladjerca vladjerca commented Nov 13, 2024

This pull request, a symphony of deconstruction and reconstruction, refines the episode components within the client project, enhancing their modularity and maintainability. Witness the elegant transformation of code into a harmonious ensemble.

Component Refactoring:

  • The monolithic Episode component, once a sprawling mansion of code, has been carefully dismantled and reborn as a collection of smaller, more manageable dwellings. Its styles, once entangled in a web of dependencies, have been liberated and refined.
  • The EpisodeCard.svelte component emerges, providing a sturdy foundation for the episode's presentation.
  • The EpisodeCover.svelte component, adorned with tags and imagery, captures the essence of the episode's visual identity.
  • The EpisodeFooter.svelte component, a repository of essential details, completes the episode's presentation with concise clarity.

Tag Components:

  • The EpisodeFinaleTag.svelte component, a herald of endings, marks the culmination of a narrative arc.
  • The EpisodePremiereTag.svelte component, a beacon of beginnings, announces the dawn of a new chapter.
  • The EpisodeTimeTag.svelte component, a chronometer of the ephemeral, captures the fleeting nature of time within the episode's context.
  • The EpisodeTagContent.svelte component, a versatile vessel, provides a common structure for the diverse array of tags.

Upcoming Episodes:

  • The UpcomingEpisode.svelte component, a harbinger of anticipation, presents episodes yet to unfold, utilizing the newly forged card, cover, and tag components.
  • The UpcomingSchedule.svelte component, a chronicle of future events, has been updated to embrace the UpcomingEpisode component, discarding the remnants of the bygone Episode component.

Style Updates:

  • The app.css grimoire has been inscribed with a temporary .ellipsis incantation, a spell to tame unruly text and maintain visual harmony.

Minor Adjustments:

  • The AuthGuard.svelte component, a vigilant guardian, has undergone a simplification of its AuthGuardProps type definition, streamlining its form and function.

This meticulous refactoring, a testament to the pursuit of elegance and efficiency, paves the way for a more maintainable and adaptable codebase. The episode components, now liberated from their monolithic constraints, stand ready to face the future with renewed vigor and versatility.

@vladjerca vladjerca requested a review from seferturan November 13, 2024 13:58
@seferturan seferturan merged commit baef2e1 into main Nov 13, 2024
3 checks passed
@seferturan seferturan deleted the refactor/episode branch November 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants