Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollbars in safari #443

Merged
merged 2 commits into from
Feb 15, 2025
Merged

fix: scrollbars in safari #443

merged 2 commits into from
Feb 15, 2025

Conversation

seferturan
Copy link
Collaborator

@seferturan seferturan commented Feb 15, 2025

🎶 Notes 🎶

  • Safari (╯°□°)╯︵ ┻━┻
  • Scrollbars never became visible.
  • Dropdowns were hidden under the section lists.

👀 Example 👀

I removed the opacity:0, which causes safari to be buggy when it comes to displaying hiding scrollbars. Example:
https://github.com/user-attachments/assets/4929838c-f989-484d-9904-095a4e9e7cf3

So for now, the overflow-x on the lists is set on a hover.

Dropdown fix:
Before/after:
Screenshot 2025-02-15 at 16 27 22

Screenshot 2025-02-15 at 16 27 31

@seferturan seferturan requested a review from vladjerca February 15, 2025 15:32
Copy link

deepsource-io bot commented Feb 15, 2025

Here's the code health analysis summary for commits a8de957..2d9f432. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateJavascript
Branch Coverage25.4%25.4%
Composite Coverage60.6%60.6%
Line Coverage72.8%72.8%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@seferturan seferturan marked this pull request as draft February 15, 2025 15:38
@seferturan
Copy link
Collaborator Author

Drafted; when on hover setting the overflow-x still hides the dropdown

@seferturan seferturan marked this pull request as ready for review February 15, 2025 15:48
@vladjerca vladjerca merged commit f5835d4 into main Feb 15, 2025
15 checks passed
@vladjerca vladjerca deleted the fix/safari_again branch February 15, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants