Fix versioning strategy values on the UI

tramlinehq · Dec 2, 2023 · 2905982 · 2905982
1 parent 7772f16
commit 2905982
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/app/models/train.rb b/app/models/train.rb
@@ -82,6 +82,7 @@ class Train < ApplicationRecord
 
   validates :branching_strategy, :working_branch, presence: true
   validates :branching_strategy, inclusion: {in: BRANCHING_STRATEGIES.keys.map(&:to_s)}
+  validates :versioning_strategy, presence: true, inclusion: {in: Train.versioning_strategies.values}
   validates :release_backmerge_branch, presence: true, if: -> { branching_strategy == "release_backmerge" }
   validates :release_branch, presence: true, if: -> { branching_strategy == "parallel_working" }
   validate :semver_compatibility, on: :create

diff --git a/app/views/trains/_versioning_strategy.html.erb b/app/views/trains/_versioning_strategy.html.erb
@@ -3,7 +3,7 @@
 <div>
   <%= form.label "Strategy", class: "block text-sm font-medium mb-1" %>
   <%= form.select :versioning_strategy,
-                  options_for_select(Train.versioning_strategies.invert.transform_values(&:titleize), train.versioning_strategy),
+                  options_for_select(Train.versioning_strategies.transform_values(&:titleize).invert, train.versioning_strategy),
                   { required: true, },
                   { class: text_field_classes(is_disabled: train.persisted?),
                     disabled: train.persisted? } %>