Advanced notification settings #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use notification settings for sending train notifications
nid90
force-pushed
the
feat/separate-notification-settings
branch
from
d8ff57d to
69cbecb
Compare
- add back step started notif
- add notification settings view component
kitallis
approved these changes
Oct 4, 2023
| @notification_settings = notification_settings | ||
| end | ||
|
|
||
| def ordered_notification_settings |
There was a problem hiding this comment.
Suggested change
| def ordered_notification_settings | |
| def settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring each notification individually for all possible notifications during the release.
Train settings page:
Notification settings page: