Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old code #693

Merged
merged 58 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
480eb04
migration script for creating v2 models for non-v2 releases
nid90 Oct 19, 2024
675f0c5
add passports for the new models
nid90 Oct 21, 2024
6854387
staged rollout passprts, use original passport message
nid90 Oct 21, 2024
05e659e
minor fixes to view
nid90 Oct 21, 2024
5dd7a9d
fix some errant data values
nid90 Oct 21, 2024
eec5b19
fix reldex computation for v2
nid90 Oct 21, 2024
863e08f
Fix fetching external builds for release platform runs
nid90 Oct 21, 2024
092f5ea
add metrics and events, skip callbacks
nid90 Oct 21, 2024
8e25009
skip lint
nid90 Oct 21, 2024
54cc87b
Merge branch 'main' into v2/data-migration-script
nid90 Oct 23, 2024
62abdd4
Add DeprecatedSubmission for slack or external deployments
nid90 Oct 23, 2024
8717a0e
make the anonymize script more robust for interrupt failures
nid90 Oct 23, 2024
7509c91
Add hotfixes graph to devops report; fix iOS review time graph data
nid90 Oct 23, 2024
c22067a
Show the platform icon only for hotfixes applied to one platform
nid90 Oct 23, 2024
dac4433
remove un-necessary note
nid90 Oct 23, 2024
4c7680b
Merge branch 'main' into v2/data-migration-script
nid90 Oct 23, 2024
a109248
Fix adoption chart data for store rollout
nid90 Oct 23, 2024
ee067ee
Humanize the phase names for time in phases chart
nid90 Oct 23, 2024
175643a
Move all builds page to use the Build model
nid90 Oct 24, 2024
d598630
Merge branch 'main' into v2/data-migration-script
nid90 Oct 25, 2024
458301c
Merge branch 'v2/data-migration-script' into v2/all-builds
nid90 Oct 25, 2024
ea6b36c
show ready builds only
nid90 Oct 25, 2024
0ec9ae8
Merge remote-tracking branch 'origin/main' into v2/all-builds
nid90 Oct 28, 2024
c5ef292
Merge branch 'v2/all-builds' into v2/cleanup
nid90 Dec 8, 2024
9587ccc
Remove unused old models, views, controllers, helpers and js
nid90 Dec 8, 2024
7240484
Merge branch 'main' into v2/all-builds
nid90 Dec 8, 2024
d609e3f
Merge branch 'v2/all-builds' into v2/cleanup
nid90 Dec 8, 2024
32fd044
s'more
nid90 Dec 8, 2024
afbe1d6
Merge remote-tracking branch 'origin/main' into v2/cleanup
nid90 Dec 17, 2024
9c0b0eb
more removal
nid90 Dec 18, 2024
ac55d5f
Merge branch 'main' into v2/cleanup
nid90 Dec 18, 2024
2baa349
remove old notification kinds
nid90 Dec 18, 2024
960ace2
add stampable icons for missing models
nid90 Dec 18, 2024
947983b
moving some code around, deleting some
nid90 Dec 18, 2024
5889fc2
move has restricted public channel check to platform config
nid90 Dec 18, 2024
437f7b0
move check release health to production release
nid90 Dec 18, 2024
1c3f246
release has started signal
nid90 Dec 18, 2024
4eb5a63
remove metadata todo from coordinators
nid90 Dec 18, 2024
144398a
move specs to v2 models
nid90 Dec 18, 2024
39d00f6
remove parent usage
nid90 Dec 18, 2024
ed68d6b
Add the author name to the rollout events timeline
nid90 Dec 19, 2024
a74a5dd
remove releases helper
nid90 Dec 19, 2024
ce0a62c
unused partial and helper fns
nid90 Dec 19, 2024
b9de248
remove unused helpers
nid90 Dec 19, 2024
cfa669d
put back password helper, needed in signup
nid90 Dec 19, 2024
ba41a42
some more deletions
nid90 Dec 19, 2024
0deae96
remove usage of app_id from integration
nid90 Dec 19, 2024
751266a
remove more reference to v2
nid90 Dec 19, 2024
3616839
simplify app configurable module, remove platform awareness
nid90 Dec 19, 2024
2e9596c
annotations
nid90 Dec 19, 2024
cd06d96
pr comments
nid90 Dec 19, 2024
31f32e4
Merge branch 'main' into v2/cleanup
nid90 Dec 19, 2024
82a3297
move branchinf selector controller to domain directory
nid90 Dec 19, 2024
8f2a34a
rename reldex controllers
nid90 Dec 19, 2024
b922f46
fix a pending spec
nid90 Dec 19, 2024
ee31ac2
update todos
nid90 Dec 19, 2024
bf7350d
remove passport exclusions
nid90 Dec 19, 2024
195b036
fix notifications list page
nid90 Dec 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 0 additions & 8 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,12 @@ Rails/I18nLocaleTexts:
- 'app/controllers/integrations_controller.rb'
- 'app/controllers/releases_controller.rb'
- 'app/controllers/signed_in_application_controller.rb'
- 'app/controllers/steps_controller.rb'
- 'app/controllers/trains_controller.rb'
- 'app/controllers/release_platforms_controller.rb'
- 'app/controllers/commits_controller.rb'
- 'app/controllers/build_queues_controller.rb'
- 'app/controllers/accounts/organizations_controller.rb'
- 'app/mailers/test_mailer.rb'
- 'app/models/deployment.rb'
- 'app/models/step.rb'
- 'app/models/train.rb'
- 'app/controllers/deployments_controller.rb'
- 'app/controllers/step_runs_controller.rb'
- 'app/controllers/staged_rollouts_controller.rb'
- 'app/controllers/deployment_runs_controller.rb'
- 'app/controllers/release_metadata_controller.rb'
- 'app/controllers/integrations/slack_controller.rb'
- 'app/controllers/integrations/google_firebase_controller.rb'
Expand Down
19 changes: 0 additions & 19 deletions .v2_todo.yml

This file was deleted.

7 changes: 6 additions & 1 deletion app/assets/images/workflow.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions app/components/all_builds_table_component.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@

<th class="px-2 py-3 whitespace-nowrap">
<div class="font-semibold text-left">
<%= Deployment.display.pluralize %>
<span>Submissions</span>
</div>
</th>

Expand Down Expand Up @@ -118,13 +118,13 @@
<span>
<% if build.ci_link.present? %>
<%= link_to_external build.ci_link, title: "link to CI" do %>
<%= inline_svg('workflow.svg', classname: "inline-flex w-5 mr-2") %>
<%= render V2::IconComponent.new("workflow.svg", size: :lg) %>
<% end %>
<% end %>

<% if build.download_url.present? %>
<%= link_to_external build.download_url, title: "download build" do %>
<%= inline_svg('download.svg', classname: "inline-flex w-5") %>
<%= render V2::IconComponent.new("download.svg", size: :lg) %>
<% end %>
<% end %>
</span>
Expand Down
6 changes: 2 additions & 4 deletions app/components/all_builds_table_component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ class AllBuildsTableComponent < ViewComponent::Base
include Pagy::Frontend
include ApplicationHelper
include LinkHelper
include AssetsHelper
include ReleasesHelper
include DeploymentsHelper

def initialize(builds:, paginator:, query_params:)
@builds = builds
Expand Down Expand Up @@ -35,7 +32,8 @@ def sort_indicator
end

def release_status(build)
release_status_badge(build.release_status)
ReleasePresenter::RELEASE_STATUS.fetch(build.release_status.to_sym) => {text:, status:}
status_badge(text, status)
end

def release_platform(build)
Expand Down
14 changes: 0 additions & 14 deletions app/components/build_health_component.html.erb

This file was deleted.

86 changes: 0 additions & 86 deletions app/components/build_health_component.rb

This file was deleted.

15 changes: 0 additions & 15 deletions app/components/build_metadata_component.html.erb

This file was deleted.

34 changes: 0 additions & 34 deletions app/components/build_metadata_component.rb

This file was deleted.

1 change: 0 additions & 1 deletion app/components/chart_component.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
class ChartComponent < V2::BaseComponent
include AssetsHelper
using RefinedHash
CHART_TYPES = %w[area line stacked-bar polar-area]
InvalidChartType = Class.new(StandardError)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<span class="mr-3 flex flex-col items-center"><%= author_avatar(passport.author_full_name) %></span>
<div class="border border-slate-200 rounded-lg px-3 py-3 bg-white flex flex-row items-center my-2">
<div class="<%= passport_badge(passport) %> rounded-lg text-center p-0.5 mr-2 flex items-center">
<%= inline_svg("#{passport_icon(passport)}.svg", classname: "inline-flex antialiased w-5") %>
<%= render V2::IconComponent.new("#{passport_icon(passport)}.svg", size: :lg, classes: "antialiased") %>
</div>
<div class="text-sm leading-5 font-normal text-slate-700"><%= raw(passport.message) %></div>
</div>
10 changes: 6 additions & 4 deletions app/components/event_timeline/event_message_component.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
class EventTimeline::EventMessageComponent < ViewComponent::Base
include AssetsHelper
include ApplicationHelper

STAMPABLE_ICONS = {
DeploymentRun => "truck_delivery",
StoreSubmission => "truck_delivery",
Commit => "git_commit",
StepRun => "box",
PreProdRelease => "box",
ProductionRelease => "box",
ReleasePlatformRun => "bolt",
Release => "bolt"
Release => "bolt",
WorkflowRun => "workflow",
Build => "drill"
}

BADGE = {
Expand Down
2 changes: 1 addition & 1 deletion app/components/event_timeline_component.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<% end %>

<div class="flex flex-col items-center mb-2 bg-backgroundLight dark:bg-backgroundDark py-1">
<%= inline_svg('calendar_time.svg', classname: "inline-flex w-10") %>
<%= render V2::IconComponent.new("calendar_time.svg", size: :xl_3) %>
<time class="text-xl font-semibold text-main-900"><%= day %></time>
<%= toggle_for(hide_timeline?(index)) %>
</div>
Expand Down
6 changes: 1 addition & 5 deletions app/components/event_timeline_component.rb
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
class EventTimelineComponent < ViewComponent::Base
include ApplicationHelper
include AssetsHelper

def initialize(app:, events:)
@app = app
@events = events
end

EXCLUSIONS = {
"DeploymentRun" => ["created"],
"StepRun" => %w[build_available finished]
}
EXCLUSIONS = {}

def events_by_days
@events
Expand Down
Loading
Loading