Mb mb before asdf node changes dont merge #11100

mboren · 2023-07-24T19:48:09Z

Jira ticket

Summary

Hypothesis: asdf changes could be causing problems with ephemeral deploys
So I made this branch point to the commit right before that was merged into main.

I had to make a base something old because it doesnt let you make a PR without any changes.

Verification Steps for the Author

These are to be checked by the author.

Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

Setup to Run the Code

How to test

Access the
Login as a

Frontend

There are no aXe warnings for UI.
This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
There are no new console errors in the browser devtools.
There are no new console errors in the test output.
If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

Code follows the guidelines for Logging.
The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

Follows our guidelines for Zero-Downtime Deploys.
Have been communicated to #g-database.
Secure migrations have been tested following the instructions in our docs.

Screenshots

This is for MakeHHGMoveInSITWithAddressChangeRequestOver50Miles.

This is for MakeHHGMoveInSITWithAddressChangeRequestUnder50Miles.

This is for MakeHHGMoveIn200DaysSITEndsToday.

This is for MakeHHGMoveIn200DaysSITEndsTomorrow.

This is for MakeHHGMoveIn200DaysSITEndsYesterday.

This is for MakeHHGMoveIn200DaysSITDeparted.

This is for MakeHHGMoveIn200DaysSITStartsInFuture. There is not Destination SIT service items on this `testharness` so I didn't add DDSFSC here. But we might want to do that in later iterations.

…napproved-dosfsc-ddsfsc [ MB-16350 ] DOSFSC and DDSFSC move with unapproved SIT service items

…-ddsfsc

…approved-dosfsc-ddsfsc [ MB-16350 ] DOSFSC and DDSFSC move with approved SIT service items

The support API for creating a move task order did not include logic to set the GBLOC. Since the Prime regularly uses this endpoint to generate moves for their testing, this was causing issues downstream due to a null GBLOC. This fix fetches the appropriate GBLOC value based on the origin duty location address.

…16266-add-address-change-detail-to-office-responses

Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.297 to 1.44.298. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.297...v1.44.298) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [gotest.tools/gotestsum](https://github.com/gotestyourself/gotestsum) from 1.10.0 to 1.10.1. - [Release notes](https://github.com/gotestyourself/gotestsum/releases) - [Commits](gotestyourself/gotestsum@v1.10.0...v1.10.1) --- updated-dependencies: - dependency-name: gotest.tools/gotestsum dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [jest-canvas-mock](https://github.com/hustcc/jest-canvas-mock) from 2.5.1 to 2.5.2. - [Release notes](https://github.com/hustcc/jest-canvas-mock/releases) - [Changelog](https://github.com/hustcc/jest-canvas-mock/blob/master/CHANGELOG.md) - [Commits](https://github.com/hustcc/jest-canvas-mock/commits) --- updated-dependencies: - dependency-name: jest-canvas-mock dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [dotenv](https://github.com/motdotla/dotenv) from 16.1.4 to 16.3.1. - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv@v16.1.4...v16.3.1) --- updated-dependencies: - dependency-name: dotenv dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…tools/gotestsum-1.10.1 Bump gotest.tools/gotestsum from 1.10.0 to 1.10.1

…canvas-mock-2.5.2 Bump jest-canvas-mock from 2.5.1 to 2.5.2

…com/aws/aws-sdk-go-1.44.298 Bump github.com/aws/aws-sdk-go from 1.44.297 to 1.44.298

…-cookie-4.1.3 Bump tough-cookie from 4.0.0 to 4.1.3

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.1 to 7.22.8. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.8/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…v-16.3.1 Bump dotenv from 16.1.4 to 16.3.1

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.8 to 3.0.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.8...3.0.0) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

- Fiddled around with some pointer stuff - Fixed a typo that made the handleError function return the wrong error for conflict errors - Fixed a typo that made the test for conflict errors use a mock not found response - Gave not found error responses a payload (and refactored out the identical payloads used in the other error responses) - Removed check for payload of 500 response. I'm not 100% sure if this is right. I see some of our handlers return payloads for 500s, and some that do not.

These tests were failing because the default moves that were created were in DRAFT status

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

…wrap-1.2.4 Bump word-wrap from 1.2.3 to 1.2.4

…hipment-address-update-request' of https://github.com/transcom/mymove into MB-16402-New-office-API-endpoint-allows-TOO-to-review-shipment-address-update-request

Bumps [github.com/pterm/pterm](https://github.com/pterm/pterm) from 0.12.62 to 0.12.63. - [Release notes](https://github.com/pterm/pterm/releases) - [Changelog](https://github.com/pterm/pterm/blob/master/CHANGELOG.md) - [Commits](pterm/pterm@v0.12.62...v0.12.63) --- updated-dependencies: - dependency-name: github.com/pterm/pterm dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…com/pterm/pterm-0.12.63 Bump github.com/pterm/pterm from 0.12.62 to 0.12.63

…ipment

…item_tests MB-16478 - Fix brittle service item tests

…ipment

…erts-on-edit-shipment MB-16269 address change alerts to shipment form

…ovals requested to approved.

…int-allows-TOO-to-review-shipment-address-update-request create a new endpoint for review address update

…ymove into MB-16422-create-DDSFSC-pricer

MB-16422 create DDSFSC pricer

robot-mymove · 2023-07-24T19:58:32Z

Test coverage on server failed.

Last run: Mon 24 Jul 2023 07:58:32 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

robot-mymove · 2023-07-24T19:58:33Z

	Warnings
⚠️	Please add the JIRA issue key to the PR title (e.g. MB-123)
⚠️	Files located in legacy directories (src/shared or src/scenes) have been edited. Are you sure you don’t want to also relocate them to the new file structure? View the frontend file org ADR for more information

Generated by 🚫 dangerJS against cf04153

rogeruiz and others added 30 commits July 7, 2023 20:32

Adding DOSFSC & DDSFSC to SIT testharness;

e6017e0

This is for MakeHHGMoveInSITWithAddressChangeRequestOver50Miles.

Adding DOSFSC & DDSFSC to SIT testharness;

3e82eaf

This is for MakeHHGMoveInSITWithAddressChangeRequestUnder50Miles.

Adding DOSFSC & DDSFSC to SIT testharness;

1b72c71

This is for MakeHHGMoveIn200DaysSITEndsToday.

Adding DOSFSC & DDSFSC to SIT testharness;

0290d75

This is for MakeHHGMoveIn200DaysSITEndsTomorrow.

Adding DOSFSC & DDSFSC to SIT testharness;

805ae23

This is for MakeHHGMoveIn200DaysSITEndsYesterday.

Adding DOSFSC & DDSFSC to SIT testharness;

aa3671d

This is for MakeHHGMoveIn200DaysSITDeparted.

Adding DOSFSC to SIT testharness;

cf8054b

This is for MakeHHGMoveIn200DaysSITStartsInFuture. There is not Destination SIT service items on this `testharness` so I didn't add DDSFSC here. But we might want to do that in later iterations.

Merge pull request #11021 from transcom/rogeruiz/mb-16350/move-with-u…

16d2102

…napproved-dosfsc-ddsfsc [ MB-16350 ] DOSFSC and DDSFSC move with unapproved SIT service items

MB-16267 nest ternary properly

c4a9512

Merge branch 'main' into MB-16267-FE-TOO-address-change-alerts

7b6acd5

Merge branch 'main' into rogeruiz/mb-16350/moves-with-approved-dosfsc…

9dc00eb

…-ddsfsc

Merge pull request #11022 from transcom/rogeruiz/mb-16350/moves-with-…

e40c6b4

…approved-dosfsc-ddsfsc [ MB-16350 ] DOSFSC and DDSFSC move with approved SIT service items

Merge branch 'main' of https://github.com/transcom/mymove into PD-MB-…

ceeb15b

…16266-add-address-change-detail-to-office-responses

MB-12627 remove comments

5bcff71

Merge branch 'main' into MB-16267-FE-TOO-address-change-alerts

c9b1217

Merge pull request #11027 from transcom/dependabot/go_modules/gotest.…

556a49d

…tools/gotestsum-1.10.1 Bump gotest.tools/gotestsum from 1.10.0 to 1.10.1

Merge pull request #11029 from transcom/dependabot/npm_and_yarn/jest-…

e2f9386

…canvas-mock-2.5.2 Bump jest-canvas-mock from 2.5.1 to 2.5.2

Merge pull request #11026 from transcom/dependabot/go_modules/github.…

a54802d

…com/aws/aws-sdk-go-1.44.298 Bump github.com/aws/aws-sdk-go from 1.44.297 to 1.44.298

Merge pull request #11025 from transcom/dependabot/npm_and_yarn/tough…

3be22d8

…-cookie-4.1.3 Bump tough-cookie from 4.0.0 to 4.1.3

Converting eager preloads of MTO Agents to exclude deleted scope

440cb8d

Merge pull request #11031 from transcom/dependabot/npm_and_yarn/doten…

18d1b6b

…v-16.3.1 Bump dotenv from 16.1.4 to 16.3.1

Merge branch 'main' into kc/fixing-gbloc-issue-in-support-api

37958f4

dymonmoore and others added 25 commits July 18, 2023 21:36

updating failing handler tests.

000ff4c

Make sure we're working with approved moves in tests

c016e05

These tests were failing because the default moves that were created were in DRAFT status

Merge pull request #11081 from transcom/dependabot/npm_and_yarn/word-…

d8424e0

…wrap-1.2.4 Bump word-wrap from 1.2.3 to 1.2.4

add longer description.

d472ded

Merge branch 'MB-16402-New-office-API-endpoint-allows-TOO-to-review-s…

7b40c12

…hipment-address-update-request' of https://github.com/transcom/mymove into MB-16402-New-office-API-endpoint-allows-TOO-to-review-shipment-address-update-request

add shipment as global tag.

97b321f

add shipment as global tag.

9f878a1

Merge pull request #11083 from transcom/dependabot/go_modules/github.…

46b61c2

…com/pterm/pterm-0.12.63 Bump github.com/pterm/pterm from 0.12.62 to 0.12.63

Merge branch 'main' into MB-16478-Fix_brittle_service_item_tests

8e668c5

Merge branch 'main' into PD-MB-16269-address-change-alerts-on-edit-sh…

424d9ae

…ipment

Merge pull request #11068 from transcom/MB-16478-Fix_brittle_service_…

97bfcb5

…item_tests MB-16478 - Fix brittle service item tests

Merge branch 'main' into PD-MB-16269-address-change-alerts-on-edit-sh…

f9d7b77

…ipment

Merge pull request #11070 from transcom/PD-MB-16269-address-change-al…

ed189a8

…erts-on-edit-shipment MB-16269 address change alerts to shipment form

eager preload original/new address, and test that move goes from appr…

d46d919

…ovals requested to approved.

Merge pull request #11020 from transcom/MB-16402-New-office-API-endpo…

8fa906d

…int-allows-TOO-to-review-shipment-address-update-request create a new endpoint for review address update

apply minimum weight to DDSFSC

5cf45da

rename pricer and add mock

97c833f

Merge branch 'main' into MB-16422-create-DDSFSC-pricer

4ee1491

remove conditional for DDSFSC in seed data

e6a6fc7

Merge branch 'MB-16422-create-DDSFSC-pricer' of github.com:transcom/m…

82d358d

…ymove into MB-16422-create-DDSFSC-pricer

remove comment

3093a9f

Merge pull request #11080 from transcom/MB-16422-create-DDSFSC-pricer

cf04153

MB-16422 create DDSFSC pricer

mboren added the do not merge label Jul 24, 2023

mboren closed this Jul 24, 2023

mboren deleted the mb-MB-before-asdf-node-changes-dont-merge branch July 24, 2023 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mb mb before asdf node changes dont merge #11100

Mb mb before asdf node changes dont merge #11100

mboren commented Jul 24, 2023 •

edited

Loading

robot-mymove commented Jul 24, 2023

robot-mymove commented Jul 24, 2023

Mb mb before asdf node changes dont merge #11100

Mb mb before asdf node changes dont merge #11100

Conversation

mboren commented Jul 24, 2023 • edited Loading

Jira ticket

Summary

Verification Steps for the Author

Verification Steps for Reviewers

Setup to Run the Code

How to test

Frontend

Backend

Database

Any new migrations/schema changes:

Screenshots

robot-mymove commented Jul 24, 2023

Test coverage on server failed.

robot-mymove commented Jul 24, 2023

mboren commented Jul 24, 2023 •

edited

Loading