Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAC/ LOA parser #11141

Closed
wants to merge 38 commits into from
Closed

TAC/ LOA parser #11141

wants to merge 38 commits into from

Conversation

deandreJones
Copy link
Contributor

Jira ticket

Summary

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

Setup to Run the Code

How to test

  1. Access the
  2. Login as a

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

cameroncaci and others added 20 commits July 17, 2023 19:13
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
… *Added TAC package and tests for initial TRDM .txt file handling *Added dummy data for a TAC file
…s for pruning expired tacs. Also added consolidation functionality for duplicate TACs found
…et values in test to prevent mismatched time.now. Fixed consildating function and test. Fixed expired tac test
…dFromTRDM struct as all fields are desired, null or not besides the main sys id. Left comment of how LOA struct deviates from the matrix
…onger needed due to the updated TAC struct. Additionally, remodeled existing TAC parser package and tests to reflect the incoming sync with new TAC struct fields and pointers
@deandreJones deandreJones reopened this Aug 1, 2023
@deandreJones deandreJones reopened this Aug 1, 2023
@deandreJones deandreJones marked this pull request as ready for review August 1, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants