-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAC/ LOA parser #11141
Closed
Closed
TAC/ LOA parser #11141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…ymove into E-04364-tac-model-updates
… *Added TAC package and tests for initial TRDM .txt file handling *Added dummy data for a TAC file
…s for pruning expired tacs. Also added consolidation functionality for duplicate TACs found
…et values in test to prevent mismatched time.now. Fixed consildating function and test. Fixed expired tac test
…dFromTRDM struct as all fields are desired, null or not besides the main sys id. Left comment of how LOA struct deviates from the matrix
…onger needed due to the updated TAC struct. Additionally, remodeled existing TAC parser package and tests to reflect the incoming sync with new TAC struct fields and pointers
B 16906 tac parser
…pping functaionlity and tests for this struct. Adjusted TAC and LOA tests as needed to remove struct field comparison. Added golangci-lint.
Removed TAC and LOA struct for tracking TRDM file records. Removed ma…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots