B-18545 safety queue and labels #12732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganwc
changed the title
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
pambecker
approved these changes
Jun 10, 2024
…e-and-Labels' into B-18545-Safety-Queue-and-Labels
pambecker
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Since you reverted some changes to the test removed the updates for "Page1"/"Page2", you will also need to make this change and open a PR for int.
There was a problem hiding this comment.
I'm not reverting the tests because they were still flaky.
pambecker
approved these changes
Jun 11, 2024
paulstonebraker
approved these changes
Jun 11, 2024
| @@ -89,7 +89,6 @@ func (suite *OrderServiceSuite) TestListOrders() { | |||
|
|
|||
| // Make a postal code and GBLOC → AGFM | |||
| factory.FetchOrBuildPostalCodeToGBLOC(suite.DB(), agfmPostalCode, "AGFM") | |||
|
|
|||
There was a problem hiding this comment.
I really liked this space 😞
There was a problem hiding this comment.
It's time to let it go Paul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
INT PR