-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 19996 #12978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes same as INT
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
B-19996
Integration Review
Summary
Please ensure that B-19997 is merged prior to this review.
This task updates the TOO role to show when a domestic crating service item is Standalone in the UI. When a standalone shipment is up for approval, it will be displayed with a '- Standalone' tag on it to alert the TOO.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Setup: Run db_dev_fresh to ensure db changes are in place
Note: When testing I found that many of the service items for existing data are not complete, and will cause the creation of a payment request to error out. To test a payment request with multiple service items it is easiest to just create them yourself.
Access the Office app
Login to the Prime Sim
Add a domestic crating service item with the standalone box checked.
Login as a TOO
Find the Move you edited in the Prime Sim
Note that the newly created service item show '- Standalone' next to the name
Approve the newly created Service Item
Verify it shows ' - Standalone' after the service item has been approved
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots