B 19894 too queue moves int #13005
Merged
B 19894 too queue moves int #13005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…show up for New Move filter choice
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
|
Flaky test failures, functionality can still be reviewed |
traskowskycaci
requested review from
danieljordan-caci,
a team,
deandreJones,
TevinAdams,
cameroncaci and
brooklyn-welsh
loganwc
reviewed
Jun 12, 2024
| } | ||
| } | ||
| query.Where("moves.status in (?)", translatedStatuses) | ||
| query.Where("moves.status IN (?)", statuses) |
There was a problem hiding this comment.
this is so much cleaner than the way it was done before, nice job!
danieljordan-caci
requested changes
Jun 12, 2024
loganwc
approved these changes
Jun 12, 2024
cameroncaci
requested changes
Jun 12, 2024
danieljordan-caci
approved these changes
Jun 12, 2024
deandreJones
approved these changes
Jun 12, 2024
cameroncaci
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The large number of commits here are a result of bringing in the latest main.
See main branch for commits to pay attention to as part of 19894 work: main...B-19894-TOO-queue-moves-MAIN
Agility ticket
Summary
This work is to show only moves with the following statuses in the TOO queue:
New MoveService Counseling CompletedApprovals RequestedPreviously, the TOO queue had filter status dropdowns for:
New MoveApprovals RequestedApprovedTo test:
New MoveService Counseling CompletedApprovals RequestedFix:
Before making any changes, I discovered that the New Move drop down status filter actually showed both New Move moves and Service Counseling Completed moves which was funky. I removed this interesting filtering in
pkg/services/order/order_fetcher.goandpkg/services/move/move_searcher.go.Changes:
I removed the status enum values from being defined in
swagger-def/ghc.yaml. I found this to be unnecessary as we are now handling the status filter inpkg/handlers/ghcapi/queues.go, which is also where we are handling the status filter for the SC and TIO roles as well.Had to make the tests happy as well - lots of tests use "Approved" as the status for TOO actions, and that status no longer appears in the TOO queue. A few NTS tests were fixed as well. The NTS tests in question used a "Submitted" status move initially in the test generation but then moved it to "Approved" so I modified those tests to search for the move as a TOO rather than expect it in the TOO queue.