Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B 20641 upgrade go 1.23.1 nodejs 18.20.4 main #13724

Merged
merged 29 commits into from
Oct 7, 2024
Merged

B 20641 upgrade go 1.23.1 nodejs 18.20.4 main #13724

merged 29 commits into from
Oct 7, 2024

Conversation

cameroncaci
Copy link
Contributor

@cameroncaci cameroncaci commented Sep 16, 2024 •
edited
Loading

Link to Integration PR

Agility ticket

Summary

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Related article

The godebug placed in go.mod is brand new functionality that came with 1.23
https://go.dev/doc/godebug

Upgrade guide
https://transcom.github.io/mymove-docs/docs/backend/guides/how-to/upgrade-go-version

@cameroncaci cameroncaci self-assigned this Sep 19, 2024
@cameroncaci cameroncaci added Mountain Movers Movin' Mountains 1 Sprint at a time MAIN labels Sep 19, 2024
@cameroncaci cameroncaci changed the title B 20631 upgrade go 1.23.0 nodejs 18.20.4 main B 20641 upgrade go 1.23.0 nodejs 18.20.4 main Sep 25, 2024
@cameroncaci cameroncaci marked this pull request as ready for review September 25, 2024 12:38
@cameroncaci cameroncaci requested a review from a team as a code owner September 25, 2024 12:38
@cameroncaci cameroncaci changed the title B 20641 upgrade go 1.23.0 nodejs 18.20.4 main B 20641 upgrade go 1.23.1 nodejs 18.20.4 main Sep 25, 2024
@cameroncaci cameroncaci merged commit a317e01 into main Oct 7, 2024
43 checks passed
@cameroncaci cameroncaci deleted the b-20631-upgrade-go-1.23.0-nodejs-18.20.4-main branch October 7, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deandreJones deandreJones deandreJones approved these changes

@danieljordan-caci danieljordan-caci danieljordan-caci approved these changes

@TevinAdams TevinAdams Awaiting requested review from TevinAdams TevinAdams was automatically assigned from transcom/mountain-movers

@traskowskycaci traskowskycaci Awaiting requested review from traskowskycaci traskowskycaci was automatically assigned from transcom/mountain-movers

Assignees

@cameroncaci cameroncaci

Labels
MAIN Mountain Movers Movin' Mountains 1 Sprint at a time
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameroncaci @deandreJones @danieljordan-caci