B19795 main doc viewer doc title change #13740
Open
+427
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
taeJungCaci
requested changes
Sep 19, 2024
src/components/DocumentViewerFileManager/DocumentViewerFileManager.jsx
Outdated
Show resolved
Hide resolved
JamesHawks224
force-pushed
the
B19795-MAIN-Doc-viewer-doc-title-change
branch
from
61b5b71
to
4c83442
Compare
|
As per Dre, the coverage test needs to pass for these to get merged in now. |
|
@deandreJones want you to see this and get your thoughts To attempt to satisfy code coverage tests have been added in this PR that are not existing in INT. You cool with that? |
its unfortunate that the coverage wasn't caught in INT- but any changes that are needed for this branch to pass builds, must be put back into integrationTesting- prior to this branch merging into main |
|
Added a few tests and got enough coverage to pass. I will merge this once we get that INT PR created and merged in @JamesHawks224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
B19795
INT PR
13776
Summary/Testing/ANDI/Screenshots