Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 20977 usmc moves search #13935

Merged
merged 8 commits into from
Oct 21, 2024
Merged

B 20977 usmc moves search #13935

merged 8 commits into from
Oct 21, 2024

Conversation

KonstanceH
Copy link
Contributor

B-20977

Summary

IntegrationPR: #13836

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

  1. Create Customer with USMC
  2. Create Move/Shipment complete and sign
  3. Search for move code (any office user role)
  4. Confirm destination GBLOC shows USMC/geographic GBLOC
    example: "USMC/KKFA"

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Screenshots

USMC added to detination GBLOC
Screenshot 2024-10-04 at 12 44 46 AM

@KonstanceH KonstanceH self-assigned this Oct 16, 2024
@KonstanceH KonstanceH added ByteSize M&Ms Team ByteSized M&Ms MAIN labels Oct 16, 2024
@KonstanceH KonstanceH marked this pull request as ready for review October 16, 2024 21:31
@KonstanceH KonstanceH requested a review from a team as a code owner October 16, 2024 21:31
Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽

Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-checked this one and I think the reason it has some errors is that there's at least 1 PR that is supposed to go in before this one? Can you confirm that?

@KonstanceH
Copy link
Contributor Author

I re-checked this one and I think the reason it has some errors is that there's at least 1 PR that is supposed to go in before this one? Can you confirm that?

oh yikes, I'm on the case now

Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽

@WeatherfordAaron WeatherfordAaron merged commit 51f5619 into main Oct 21, 2024
41 checks passed
@WeatherfordAaron WeatherfordAaron deleted the B-20977-USMC-Moves-Search branch October 21, 2024 14:22
@deandreJones deandreJones restored the B-20977-USMC-Moves-Search branch October 22, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms MAIN
Development

Successfully merging this pull request may close these issues.

3 participants