Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 20599 customer portal button int #13941

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

KonstanceH
Copy link
Contributor

@KonstanceH KonstanceH commented Oct 17, 2024

B-20559

Summary

This PR just changes the labels for the customer's editing buttons to make their purpose more clear.
This also adds back in the correct version of the mobile home shipment example that was accidentally overwritten here: https://github.com/transcom/mymove/pull/13923/files

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Create any move as a customer
  2. Click on "review request"
  3. Confirm the ability to edit customer orders
  4. Confirm the label change of the uploading doc buttons.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Screenshots

Button Label changes
Screenshot 2024-10-17 at 2 12 50 PM

Customer Editing orders:
Screenshot 2024-10-17 at 2 13 43 PM

@KonstanceH KonstanceH added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Oct 17, 2024
@KonstanceH KonstanceH self-assigned this Oct 17, 2024
@KonstanceH KonstanceH marked this pull request as ready for review October 17, 2024 19:15
Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽

@KonstanceH KonstanceH merged commit e85ea79 into integrationTesting Oct 22, 2024
30 checks passed
@KonstanceH KonstanceH deleted the B-20599-Customer-Portal-Button-INT branch October 22, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

3 participants