Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int b 21071 name column filtering on partial #13961

Open
wants to merge 20 commits into
base: integrationTesting
Choose a base branch
from

Conversation

ryan-mchugh
Copy link

@ryan-mchugh ryan-mchugh commented Oct 18, 2024

[B-21071](Latent: Filter columns to be more user friendly - Name)

Summary

Improving filtering for the "Customer name" column for Moves queue & Payment Requests queue.
This will support searching partial text within both the first and last names (prior implementation was last name only)

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

  1. Pull in branch and run the application with db migrations loaded.

How to test

Moves Queue

  1. Access the Office app
  2. Login as a Services Counselor or TOO
  3. Ensure the "Counseling Queue"/"Task Order Queue" tab is selected
  4. Search a partial/whole name

Payment Requests Queue

  1. Access the Officer app
  2. Login as a TIO
  3. Ensure the "Payment Request Queue" tab is selected
  4. Search a partial/whole name

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

image image

@ryan-mchugh ryan-mchugh self-assigned this Oct 18, 2024
@samaysofo
Copy link

@ryan-mchugh is the pr supposed to still be a draft ? it's seems to have some conflicts too.

…INT-B-21071-name_column_filtering_on_partial
@ryan-mchugh ryan-mchugh marked this pull request as ready for review October 21, 2024 20:56
@brianmanley-caci
Copy link
Contributor

@ryan-mchugh one thing I did notice is that if you enter a first name and then the last name (e.g. 'John Smith') it does not return results, but if you enter last name then first name (e.g. 'Smith John') then it does return results. That may not be how they intend to use the filter anyways since the names do appear as [Last, First] on the page, but it is an observation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go-Rillaz Go-Rillaz INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

3 participants