-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-21363 Prime Updates INT #13976
Open
traskowskycaci
wants to merge
14
commits into
integrationTesting
Choose a base branch
from
B-21363-prime-int
base: integrationTesting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
B-21363 Prime Updates INT #13976
+315
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traskowskycaci
added
Mountain Movers
Movin' Mountains 1 Sprint at a time
INTEGRATION
Slated for Integration Testing
labels
Oct 22, 2024
traskowskycaci
requested review from
brooklyn-welsh,
KonstanceH,
a team,
deandreJones,
danieljordan-caci,
TevinAdams and
cameroncaci
October 22, 2024 19:31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FF off
{
"detail": "Unaccompanied baggage shipments can't be created unless the unaccompanied_baggage feature flag is enabled.",
"instance": "0cde4c1d-bf11-47dc-b431-e3aa70219916",
"title": "Validation Error",
"invalidFields": null
}
FF on
{
"actualDeliveryDate": null,
"actualPickupDate": null,
"actualProGearWeight": null,
"actualSpouseProGearWeight": null,
"approvedDate": null,
"createdAt": "2024-10-22T21:07:17.965Z",
"destinationAddress": {
"city": "Fort Eisenhower",
"country": "US",
"county": "COLUMBIA",
"eTag": "MjAyNC0xMC0yMlQyMTowNzoxNy45NjMzMzZa",
"id": "55db9ce1-db89-4a04-b21c-72baee0e3f0a",
"postalCode": "30813",
"state": "GA",
"streetAddress1": "N/A"
},
"eTag": "MjAyNC0xMC0yMlQyMTowNzoxNy45NjU5NjVa",
"firstAvailableDeliveryDate": null,
"id": "e3d1c723-a461-4d8d-954a-5770e2faaa63",
"marketCode": "d",
"moveTaskOrderID": "39e1c5c1-0ebd-4f6e-93ad-9103493bd31c",
"pickupAddress": {
"city": "Nicholasville",
"country": "US",
"county": "JESSAMINE",
"eTag": "MjAyNC0xMC0yMlQyMTowNzoxNy45NTM4Nzha",
"id": "db6ef5a7-0790-4c64-80ba-da7aa9b108cb",
"postalCode": "40356",
"state": "KY",
"streetAddress1": "123 Main St"
},
"primeEstimatedWeightRecordedDate": null,
"requestedDeliveryDate": null,
"requestedPickupDate": "2024-10-04",
"requiredDeliveryDate": null,
"scheduledDeliveryDate": null,
"scheduledPickupDate": null,
"shipmentType": "UNACCOMPANIED_BAGGAGE",
"status": "SUBMITTED",
"updatedAt": "2024-10-22T21:07:17.965Z",
"mtoServiceItems": []
}
working as designed |
deandreJones
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
First B-21363 PR (combined with B-21362)
Second B-21363 PR
Summary
Adding unaccompanied_baggage FF checks to the prime API's createMTOShipment endpoints (v2 and v3, even though I think only v3 is used)
To test:
Example body for creating a UB shipment:
v2, FF false
http://primelocal:3000/prime/v2/mto-shipments
v3, FF false
http://primelocal:3000/prime/v3/mto-shipments
v2, FF true
http://primelocal:3000/prime/v2/mto-shipments
v3, FF true
http://primelocal:3000/prime/v3/mto-shipments