Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21363 Prime Updates INT #13976

Open
wants to merge 14 commits into
base: integrationTesting
Choose a base branch
from
Open

Conversation

traskowskycaci
Copy link
Contributor

@traskowskycaci traskowskycaci commented Oct 22, 2024

Agility ticket

First B-21363 PR (combined with B-21362)

Second B-21363 PR

Summary

Adding unaccompanied_baggage FF checks to the prime API's createMTOShipment endpoints (v2 and v3, even though I think only v3 is used)

To test:
Example body for creating a UB shipment:

{
  "moveTaskOrderID": "91154a53-6880-460b-a270-57bcb53d631a",
  "shipmentType": "UNACCOMPANIED_BAGGAGE",
  "requestedPickupDate": "2024-10-04",
  "pickupAddress": {
      "streetAddress1": "123 Main St",
      "city": "Nicholasville",
      "state": "KY",
      "postalCode": "40356",
      "country": "US",
      "county": "JESSAMINE"
   }
}

v2, FF false

  1. Make sure unaccompanied_baggage feature flag is false in your .envrc.
  2. Call the v2 createMTOShipment: http://primelocal:3000/prime/v2/mto-shipments
  3. Verify that you receive a 422 response with a message of "Unaccompanied baggage shipments can't be created unless the unaccompanied_baggage feature flag is enabled"

v3, FF false

  1. Make sure unaccompanied_baggage feature flag is false in your .envrc.
  2. Call the v2 createMTOShipment: http://primelocal:3000/prime/v3/mto-shipments
  3. Verify that you receive a 422 response with a message of "Unaccompanied baggage shipments can't be created unless the unaccompanied_baggage feature flag is enabled"

v2, FF true

  1. Make sure unaccompanied_baggage feature flag is true in your .envrc.
  2. Call the v2 createMTOShipment: http://primelocal:3000/prime/v2/mto-shipments
  3. Verify that you receive a 200 and can create the UB shipment

v3, FF true

  1. Make sure unaccompanied_baggage feature flag is true in your .envrc.
  2. Call the v2 createMTOShipment: http://primelocal:3000/prime/v3/mto-shipments
  3. Verify that you receive a 200 and can create the UB shipment

@traskowskycaci traskowskycaci changed the title B 21363 prime int B-21363 Prime Updates INT Oct 22, 2024
@traskowskycaci traskowskycaci self-assigned this Oct 22, 2024
@traskowskycaci traskowskycaci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Oct 22, 2024
@traskowskycaci traskowskycaci marked this pull request as ready for review October 22, 2024 19:31
Copy link
Contributor

@deandreJones deandreJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FF off

{
  "detail": "Unaccompanied baggage shipments can't be created unless the unaccompanied_baggage feature flag is enabled.",
  "instance": "0cde4c1d-bf11-47dc-b431-e3aa70219916",
  "title": "Validation Error",
  "invalidFields": null
}

FF on

{
  "actualDeliveryDate": null,
  "actualPickupDate": null,
  "actualProGearWeight": null,
  "actualSpouseProGearWeight": null,
  "approvedDate": null,
  "createdAt": "2024-10-22T21:07:17.965Z",
  "destinationAddress": {
    "city": "Fort Eisenhower",
    "country": "US",
    "county": "COLUMBIA",
    "eTag": "MjAyNC0xMC0yMlQyMTowNzoxNy45NjMzMzZa",
    "id": "55db9ce1-db89-4a04-b21c-72baee0e3f0a",
    "postalCode": "30813",
    "state": "GA",
    "streetAddress1": "N/A"
  },
  "eTag": "MjAyNC0xMC0yMlQyMTowNzoxNy45NjU5NjVa",
  "firstAvailableDeliveryDate": null,
  "id": "e3d1c723-a461-4d8d-954a-5770e2faaa63",
  "marketCode": "d",
  "moveTaskOrderID": "39e1c5c1-0ebd-4f6e-93ad-9103493bd31c",
  "pickupAddress": {
    "city": "Nicholasville",
    "country": "US",
    "county": "JESSAMINE",
    "eTag": "MjAyNC0xMC0yMlQyMTowNzoxNy45NTM4Nzha",
    "id": "db6ef5a7-0790-4c64-80ba-da7aa9b108cb",
    "postalCode": "40356",
    "state": "KY",
    "streetAddress1": "123 Main St"
  },
  "primeEstimatedWeightRecordedDate": null,
  "requestedDeliveryDate": null,
  "requestedPickupDate": "2024-10-04",
  "requiredDeliveryDate": null,
  "scheduledDeliveryDate": null,
  "scheduledPickupDate": null,
  "shipmentType": "UNACCOMPANIED_BAGGAGE",
  "status": "SUBMITTED",
  "updatedAt": "2024-10-22T21:07:17.965Z",
  "mtoServiceItems": []
}

@deandreJones
Copy link
Contributor

working as designed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

2 participants