Clean up a bunch of code and eslint warnings (#765)

.eslintrc.js

@@ -78,6 +78,14 @@ module.exports = {
         'import/no-unused-modules': ['off', { unusedExports: false }],
       },
     },
+    // Temporarily don't enforce some rules on types and constants
+    {
+      files: ['common/styles/*.ts', 'common/constants/**/*.ts', 'common/types/**/*.ts'],
+      rules: {
+        '@typescript-eslint/no-non-null-assertion': 'error',
+        'import/no-unused-modules': ['off', { unusedExports: false }],
+      },
+    },
   ],
   ignorePatterns: ['node_modules/**/*', 'build/**/*', 'out/**/*'],
 };

common/api/slowzones.ts

@@ -3,7 +3,7 @@ import type {
   SlowZoneResponse,
   SpeedRestriction,
 } from '../../common/types/dataPoints';
-import type { FetchSpeedRestrictionsOptions } from '../types/api';
+import type { FetchSpeedRestrictionsOptions, FetchSpeedRestrictionsResponse } from '../types/api';
 import { APP_DATA_BASE_PATH } from '../utils/constants';
 import { getGtfsRailLineId } from '../utils/lines';
 
@@ -28,9 +28,17 @@ export const fetchSpeedRestrictions = async (
   );
   const today = new Date();
   const response = await fetch(speedRestrictionsUrl.toString());
-  const { available, date: resolvedDate, zones } = await response.json();
+  const {
+    available,
+    date: resolvedDate,
+    zones,
+  }: FetchSpeedRestrictionsResponse = await response.json();
   if (available) {
-    return zones.map((zone) => ({ ...zone, currentAsOf: resolvedDate, validAsOf: today }));
+    return zones.map((zone) => ({
+      ...zone,
+      currentAsOf: new Date(resolvedDate),
+      validAsOf: today,
+    }));
   }
   return [];
 };

common/components/notices/ErrorNotice.tsx

@@ -3,7 +3,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import classNames from 'classnames';
 import React from 'react';
 import { useDelimitatedRoute } from '../../utils/router';
-import { mbtaTextConfig } from '../inputs/styles/tailwind';
+import { mbtaTextConfig } from '../../styles/general';
 
 interface ErrorNoticeProps {
   isWidget?: boolean;

common/components/notices/NoDataNotice.tsx

@@ -3,7 +3,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import classNames from 'classnames';
 import React from 'react';
 import { useDelimitatedRoute } from '../../utils/router';
-import { mbtaTextConfig } from '../inputs/styles/tailwind';
+import { mbtaTextConfig } from '../../styles/general';
 
 interface NoDataNoticeProps {
   isWidget?: boolean;

common/constants/time.ts

@@ -11,3 +11,4 @@ export const TWO_HOURS = 2 * ONE_HOUR;
 export const THREE_HOURS = 3 * ONE_HOUR;
 export const FOUR_HOURS = 4 * ONE_HOUR;
 export const TWELVE_HOURS = 12 * ONE_HOUR;
+export const ONE_DAY = 24 * ONE_HOUR;

common/styles/general.ts

@@ -18,6 +18,15 @@ export const lineColorLightBorder = {
   DEFAULT: `border-stone-900`,
 };
 
+export const mbtaTextConfig: DefaultStyleMap = {
+  'line-red': `text-mbta-red`,
+  'line-orange': `text-mbta-orange`,
+  'line-green': `text-mbta-green`,
+  'line-blue': `text-mbta-blue`,
+  'line-bus': `text-mbta-bus`,
+  DEFAULT: `text-black`,
+};
+
 export const lineColorLightBackground: DefaultStyleMap = {
   'line-red': `bg-mbta-lightRed`,
   'line-orange': `bg-mbta-lightOrange`,

common/types/api.ts

@@ -1,4 +1,5 @@
 import type { AggType } from '../../modules/speed/constants/speeds';
+import type { SpeedRestriction } from './dataPoints';
 import type { Line } from './lines';
 
 export enum QueryNameKeys {
@@ -92,5 +93,5 @@ export type FetchSpeedRestrictionsOptions = {
 export type FetchSpeedRestrictionsResponse = {
   available: boolean;
   date: string;
-  zones: Record<string, any>[];
+  zones: SpeedRestriction[];
 };

common/types/dataPoints.ts

@@ -105,8 +105,8 @@ export type SpeedRestriction = {
   reported: string;
   speedMph: number;
   trackFeet: number;
-  currentAsOf: Date;
   lineId: Line;
+  currentAsOf: Date;
   validAsOf: Date;
 };
 

common/utils/headways.ts

@@ -32,22 +32,22 @@ export const longestHeadway = (headways: SingleDayDataPoint[] | AggregateDataPoi
   }
 };
 
-export const longestAggregateHeadway = (headways: AggregateDataPoint[]) => {
+const longestAggregateHeadway = (headways: AggregateDataPoint[]) => {
   return headways.reduce(
     (current, datapoint) => (datapoint.min < current.min ? datapoint : current),
     headways[0]
   );
 };
 
-export const longestSingleHeadway = (headways: SingleDayDataPoint[]) => {
+const longestSingleHeadway = (headways: SingleDayDataPoint[]) => {
   return headways.reduce((current, datapoint) => {
     if (datapoint.headway_time_sec && current.headway_time_sec)
       return datapoint.headway_time_sec > current.headway_time_sec ? datapoint : current;
     return current;
   }, headways[0]);
 };
 
-export const shortestSingleHeadway = (headways: SingleDayDataPoint[]) => {
+const shortestSingleHeadway = (headways: SingleDayDataPoint[]) => {
   return headways.reduce((current, datapoint) => {
     if (datapoint.headway_time_sec && current.headway_time_sec)
       return datapoint.headway_time_sec < current.headway_time_sec ? datapoint : current;

common/utils/slowZoneUtils.ts

@@ -57,14 +57,6 @@ export const getStationPairName = (from: Station, to: Station, short?: boolean):
   return `${from.stop_name}-${to.stop_name}`;
 };
 
-const groupByRoute = (data: SlowZone[]) =>
-  data.reduce((series: Record<string, SlowZone[]>, sz: SlowZone) => {
-    const key = sz.id;
-    const s = (series[key] || []).concat(sz);
-    series[key] = s;
-    return series;
-  }, {});
-
 const groupByLine = (data: SlowZone[]) =>
   data.reduce((series: Record<string, SlowZone[]>, sz) => {
     const key = sz.color;

common/utils/stations.ts

@@ -1,4 +1,3 @@
-import type { SelectOption } from '../../common/types/inputs';
 import type { Line, LineShort } from '../../common/types/lines';
 import type { Station } from '../../common/types/stations';
 import type { Location } from '../types/charts';
@@ -40,16 +39,6 @@ export const optionsStation = (line: LineShort, busRoute?: string): Station[] |
   return stations[line].stations.sort((a, b) => a.order - b.order);
 };
 
-export const swapStations = (
-  fromStation: SelectOption<Station> | null,
-  toStation: SelectOption<Station> | null,
-  setFromStation: (fromStation: SelectOption<Station> | null) => void,
-  setToStation: (toStation: SelectOption<Station> | null) => void
-) => {
-  setFromStation(toStation);
-  setToStation(fromStation);
-};
-
 const createStationIndex = () => {
   const index: Record<string, Station> = {};
   Object.values({ ...rtStations, ...busStations }).forEach((line) => {

modules/dashboard/HomescreenWidgetTitle.tsx

@@ -3,7 +3,6 @@ import classNames from 'classnames';
 import Link from 'next/link';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import { faChevronRight } from '@fortawesome/free-solid-svg-icons';
-import { mbtaTextConfig } from '../../common/components/inputs/styles/tailwind';
 import {
   useDelimitatedRoute,
   useGenerateHref,
@@ -13,6 +12,7 @@ import { LINE_COLORS } from '../../common/constants/colors';
 import type { Page } from '../../common/constants/pages';
 import { ALL_PAGES } from '../../common/constants/pages';
 import { getSelectedDates } from '../../common/state/utils/dateStoreUtils';
+import { mbtaTextConfig } from '../../common/styles/general';
 
 interface HomescreenWidgetTitle {
   title: string;