Shows gobble data in the dashboard #943
Conversation
Only shows gobble data when manually navigating to a bus url with a date past the current maximum
devinmatte
requested review from
austinjpaul,
idreyn,
mathcolo,
skaplan-dev and
PatrickCleary
as code owners
github-actions
bot
added
backend
|
whoa! is this on beta? |
|
We have a version of this that includes commuter rail on beta. I can push this branch up instead if we want |
|
That would be great, would you mind? |
|
@mathcolo on beta now |
server/chalicelib/s3.py
Outdated
| if is_bus(stop_id): | ||
| return "daily-bus-data" | ||
| else: | ||
| return "daily-data" |
There was a problem hiding this comment.
the other folders in Events-live/ are daily-cr-data/ and daily-rapid-data/! daily-data is a subfolder of Events/
There was a problem hiding this comment.
I have this in the other branch #898
I guess I can have all three in this branch
| @@ -20,52 +20,70 @@ | |||
| "CR-Needham", | |||
| "CR-Newburyport", | |||
| "CR-Providence", | |||
| "CR-Foxboro", | |||
There was a problem hiding this comment.
We have no foxboro data yet since it's the event line, we can add it back later but for now there's nothing really to show
| "stops": stop_layout[stop["id"]], | ||
| } | ||
| ) | ||
| except KeyError: |
There was a problem hiding this comment.
Instead of using it as a fallback, what if we always fetched from the API? My thinking is that if there's ever a problem with one of these files, it'll be easier to tell what caused it.
There was a problem hiding this comment.
So this was only occurring for Worcester, but I gave this a try for everything, and then many stops on some lines returned less possible stop ids than generating the list from s3. Meaning gobble is detecting the trains at stops that the MBTA api doesn't think they will stop at. So really what we need here is a merge imo
Motivation
Get the app in a state ready for gobble data
Changes
Only shows gobble data when manually navigating to a bus url with a date past the current maximum.
Nobody can reach gobble data through the UI, but could by changing
startDate=2024-01-22if they wanted to.Adds a new warning banner to the bottom explaining that we parsed this data ourselves
Testing Instructions