Implement SSE #90

cdr-chakotay · 2023-10-19T20:16:25Z

Implement Server Sent Events (SSE) as replacement for socket polling.

This is due to SSE preference from the Transloadit API.

…in Example

…lient now: https://github.com/CiscoSE/commons-networking/tree/main#sse-client

Acconut · 2024-01-11T09:30:45Z

Let me know if you need some more assistance here :)

cdr-chakotay · 2024-01-12T01:16:34Z

Let me know if you need some more assistance here :)

Hey @Acconut thank you for the reminder! I was occupied with other work in the meantime. I would like to continue on this soon. I let you know if I need anything :)

Acconut

This PR is looking sharp! I have only a few comments and then we can get this on the road. Congrats on getting this so far 🎉

src/main/java/com/transloadit/sdk/Assembly.java

src/main/java/com/transloadit/sdk/AssemblyListener.java

src/main/java/com/transloadit/sdk/EventsourceRunnable.java

src/test/resources/__files/sse_response_body

src/test/java/com/transloadit/sdk/AssemblyTest.java

Remove Debugging Output in EventsourceRunnable.java Stop throwing on unknown events in EventsourceRunnable.java Adjust AssemblyListener.java to reflect the new SSE functionalities

Change the SSE test resource-file's extension

Acconut

Thank you very much for the final updates! I have included a few suggestions to improve the documentation's spelling and some other minor comments. Other than that, this is good to go!

examples/src/main/java/com/transloadit/examples/ImageResizer.java

examples/src/main/java/com/transloadit/examples/KotlinExample.kt

src/main/java/com/transloadit/sdk/Assembly.java

src/main/java/com/transloadit/sdk/EventsourceRunnable.java

src/test/java/com/transloadit/sdk/AssemblyTest.java

Co-authored-by: Marius Kleidl <[email protected]>

- Change TusUploadRunnable.java and EventsourceRunnable.java visibility to package private

Also attempt to make the test thread safe.

Acconut

As far as I can tell, all feedback got addressed and the tests are passing. So this PR is good to go 🚀 Congrats on finishing this incredible work 🏅

cdr-chakotay · 2024-12-05T12:21:47Z

As far as I can tell, all feedback got addressed and the tests are passing. So this PR is good to go 🚀 Congrats on finishing this incredible work 🏅

Thanks! I will do another double-check and merge it then :)

kvz · 2024-12-06T14:33:35Z

Congrats on landing this 💪💪

we should have a column in the sdks table in the docs: supports SSE :)

Update Examples to an ENV based credential management and update Kotl…

fab1dab

…in Example

cdr-chakotay added enhancement sdks Integrations for Transloadit's API prio-2 Medium-priority issues that are important but can be addressed after high-priority tasks labels Oct 19, 2023

cdr-chakotay assigned Acconut and cdr-chakotay Oct 19, 2023

First attempt on implementing SSE, doesn't work without the socket yet.

217ec4d

cdr-chakotay force-pushed the Implement_SSE branch from b987563 to 217ec4d Compare October 19, 2023 23:47

cdr-chakotay added 6 commits November 4, 2023 01:13

Second Attempt on SSE -> Still not working. Will consider CISCO SSE C…

a5ced80

…lient now: https://github.com/CiscoSE/commons-networking/tree/main#sse-client

Second Attempt on SSE -> Still not working. Will consider CISCO SSE C…

7adf3b9

…lient now: https://github.com/CiscoSE/commons-networking/tree/main#sse-client

Merge remote-tracking branch 'origin/Implement_SSE' into Implement_SSE

76c1d55

Revert Changes. Still not working.

3e09e94

Added basic body of the Eventsource Runnable

882dc40

Prepare Handling Methods

b65e21e

Acconut removed their assignment Jan 11, 2024

cdr-chakotay added 13 commits March 20, 2024 16:28

Merge main in order to benefit from the new build settings

3467887

Add the first really working implementation of SSE

7309cf5

Add the first really working implementation of SSE

858c890

Merge remote-tracking branch 'origin/Implement_SSE' into Implement_SSE

a29f65d

Satisfy linter

74c04ea

Start with fixing unit test

5efd19a

Merge main to maintain a conflict free merging branch

7b9a097

Return Point Mock Socket before transition to SSE

42a90b8

Remove socket from MockTusAssembly

22dee3d

Patch empty JSON Object errors.

cde87d3

Add a first attempt on SSE testing

115cc4c

Add tests for Server Sent Events

24490d9

Remove Debug Output from EventsourceRunnable

76ac9af

cdr-chakotay requested a review from Acconut September 2, 2024 12:45

cdr-chakotay added 2 commits September 2, 2024 14:46

Disable auto build for examples

8a11ee7

Remove PI

0dadd7f

Acconut requested changes Sep 9, 2024

View reviewed changes

cdr-chakotay added 14 commits September 10, 2024 18:52

Activate Debugging

a334a62

Remove unnecessary URI parameter

df7f87c

Dont exit on error

dc13232

Add missing imports

1263058

Adjust Timeouts in Assembly.java

903baf0

Remove Debugging Output in EventsourceRunnable.java Stop throwing on unknown events in EventsourceRunnable.java Adjust AssemblyListener.java to reflect the new SSE functionalities

Patch Assembly Examples in order to work with the new SSE features

cf91413

Fix Linting Errors

0b7039f

Implement changes on AssemblyListener

6849072

Change the SSE test resource-file's extension

Implement changes on AssemblyListener

3f0cda4

Flip assertion order to the correct orientation

c2d3fc5

Fix some doc-strings

92aea9f

Cleanup debug line

6b284a9

Fix line

3031491

Attempt on checking JSON contents

55018aa

cdr-chakotay requested a review from Acconut November 28, 2024 21:27

Acconut requested changes Dec 3, 2024

View reviewed changes

cdr-chakotay and others added 4 commits December 3, 2024 13:14

Apply some of the suggestions from code review

7cdef7f

Co-authored-by: Marius Kleidl <[email protected]>

- Patch styling in Assembly.java

270d634

- Change TusUploadRunnable.java and EventsourceRunnable.java visibility to package private

Update test to live without the complicated map construction.

35d34a6

Also attempt to make the test thread safe.

Fix examples

652ae2e

Acconut added the breaking change Breaking change that requires a major release label Dec 5, 2024

Acconut approved these changes Dec 5, 2024

View reviewed changes

cdr-chakotay merged commit 6f6d41c into main Dec 6, 2024
5 checks passed

cdr-chakotay deleted the Implement_SSE branch December 6, 2024 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement SSE #90

Implement SSE #90

cdr-chakotay commented Oct 19, 2023

Acconut commented Jan 11, 2024

cdr-chakotay commented Jan 12, 2024

Acconut left a comment

Acconut left a comment

Acconut left a comment

cdr-chakotay commented Dec 5, 2024

kvz commented Dec 6, 2024

Implement SSE #90

Implement SSE #90

Conversation

cdr-chakotay commented Oct 19, 2023

Acconut commented Jan 11, 2024

cdr-chakotay commented Jan 12, 2024

Acconut left a comment

Choose a reason for hiding this comment

Acconut left a comment

Choose a reason for hiding this comment

Acconut left a comment

Choose a reason for hiding this comment

cdr-chakotay commented Dec 5, 2024

kvz commented Dec 6, 2024