Remove async assembly #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage ? 75.06%
Complexity ? 186
=======================================
Files ? 13
Lines ? 726
Branches ? 62
=======================================
Hits ? 545
Misses ? 146
Partials ? 35 ☔ View full report in Codecov by Sentry. |
Acconut
approved these changes
Jan 7, 2025
| * Removed the deprecated AsyncAssemblies class and functionality. | ||
|
|
||
| ##### Breaking Changes - Upgrade Guide | ||
| * The AssemblyListener Interface has been upgraded. As a result you will have to (re-) implement the following methods: |
There was a problem hiding this comment.
Suggested change
| * The AssemblyListener Interface has been upgraded. As a result you will have to (re-) implement the following methods: | |
| * The AssemblyListener interface has been upgraded. As a result you will have to implement the following methods: |
| - `onAssemblyProgress(JSONObject progress)` | ||
| - `onAssemblyResultFinished(JSONArray result)` | ||
|
|
||
| * The AsyncAssemblies class has been removed. If you were using it, you will have to switch to the regular Assembly class. |
There was a problem hiding this comment.
Suggested change
| * The AsyncAssemblies class has been removed. If you were using it, you will have to switch to the regular Assembly class. | |
| * The AsyncAssembly class has been removed. If you were using it, you will have to switch to the regular Assembly class. |
| ### 1.0.1 / 2024-11-28 ### | ||
| * Added SDK support for generating signed Smart CDN URLs (see https://transloadit.com/docs/topics/signature-authentication/#smart-cdn). | ||
| This functionality ships as Transloadit#getSignedSmartCDNUrl() - Method. | ||
| * Migrated test suite from JUnit4 to JUnit 5 | ||
| * Upgrade okhttp to 4.12.0 as a security update | ||
|
|
||
| ### 1.0.0 / 2022-12-14 ### | ||
| #### Major Release | ||
| #### Major Release |
There was a problem hiding this comment.
Suggested change
| #### Major Release | |
| #### Major Release |
|
Will have a run if I think we must clean the code a little bit if I don't find something I think we are good to go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the AsyncAssembly functionality as it is more or less obsolete.
The regular Assembly Class is capable of asynchronous uploads already and the AsyncAssembly have been marked deprecated more than a year ago.
I want to reduce complexity by removing the AsyncAssembly logic.