Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Companion stream upload unknown size files #5489

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Companion stream upload unknown size files #5489

wants to merge 19 commits into from

Commits on Oct 21, 2024

  1. stream upload unknown size files 

    behind a new option streamingUploadSizeless
COMPANION_STREAMING_UPLOAD_SIZELESS
for tus
    @mifi
    mifi committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0f34fda View commit details
    Browse the repository at this point in the history

  2. allow for all upload protocols 

    seems to be working
closes #5305
    @mifi
    mifi committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    dd3a6d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. refactor 

    and fix bug where progress was not always emitted
    @mifi
    mifi committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    503856c View commit details
    Browse the repository at this point in the history

  2. fix type

    @mifi
    mifi committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    3cd20a1 View commit details
    Browse the repository at this point in the history

  3. fix progress throttling 

    only do it on total progress
    @mifi
    mifi committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    c2e74d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Improve progress in UI 

    - only show progress percent and total bytes for files that we know the size of. (but all files will still be included in number of files)
- use `null` as an unknown value for progress and ETA, allowing us to remove ETA from UI when unknown
- `percentage` make use of `undefined` when progress is not yet known - don't show percentage in UI when unknown
- add a new state field `progress` that's the same as `totalProgress` but can also be `null`
    @mifi
    mifi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a152913 View commit details
    Browse the repository at this point in the history

  2. fix build error

    @mifi
    mifi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    633e401 View commit details
    Browse the repository at this point in the history

  3. format

    @mifi
    mifi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e3b2a1f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into companion-stream-upload-unknown-size-files

    @mifi
    mifi committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    deef05d View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. fix progress when upload complete

    @mifi
    mifi committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    96832c4 View commit details
    Browse the repository at this point in the history

  2. use execa for companion load balancer 

    if not, then it leaves zombie companion instances running in the background when e2e stops
have to be manually killed before running e2e again
    @mifi
    mifi committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a19f68e View commit details
    Browse the repository at this point in the history

  3. update docs and tests for new state.progress

    @mifi
    mifi committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c55cdf0 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. revert progress/totalProgress

    @mifi
    mifi committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3997639 View commit details
    Browse the repository at this point in the history

  2. improve doc

    @mifi
    mifi committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a6864cf View commit details
    Browse the repository at this point in the history

  3. remove option streamingUploadSizeless 

    we agreed that this can be considered not a breaking change
    @mifi
    mifi committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    927db35 View commit details
    Browse the repository at this point in the history

  4. change progress the to "of unknown"

    @mifi
    mifi committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ae08b3c View commit details
    Browse the repository at this point in the history

  5. revert

    @mifi
    mifi committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2491d20 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Merge branch 'main' into companion-stream-upload-unknown-size-files 

    # Conflicts:
#	docs/companion.md
    @mifi
    mifi committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7016f56 View commit details
    Browse the repository at this point in the history

  2. remove companion doc

    @mifi
    mifi committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ed279b5 View commit details
    Browse the repository at this point in the history