-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Next.js docs #5502
Add Next.js docs #5502
Conversation
Diff output filesNo diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work Merlijn! Left a few nits/Qs
can be a security risk**. Signature Authentication is a security measure that | ||
can prevent outsiders from tampering with your Assembly Instructions. | ||
|
||
Generating a signature should be done on the server to avoid leaking secrets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generating a signature should be done on the server to avoid leaking secrets. | |
Generating a signature should be done on the server to avoid leaking secrets. The signature itself can then be freely passed around as proof that whoever generated it, had the secrets only known to Transloadit and you as a customer. It is only valid for the instructions and time duration that the signature was generated for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I linked to the resource already as this text is already getting too long imo
import '@uppy/dashboard/dist/style.min.css'; | ||
|
||
function createUppy() { | ||
return new Uppy().use(Tus, { endpoint: '/api/upload' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're using tabs for indentation, if we switch to tabs it should be across the board i think, not just this doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all auto formatted so should be inline with everything else.
@Murderlon give me a live docs link? |
It wasn't deployed properly but now it is: https://uppy.io/docs/nextjs/ |
Closes #1958