-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go version to 1.22.7 #141
Conversation
Updated lint and vuln checks to pin to the version in go.mod file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 89.33% 86.93% -2.41%
==========================================
Files 7 7
Lines 497 375 -122
==========================================
- Hits 444 326 -118
+ Misses 48 44 -4
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Also make golangci-lint checkout and setup in the right order.
This is a bit messy. ClusterFuzz isn't enjoying the new X.Y.Z go.mod versions, and wants only X.Y. I'm trying to track down where this is coming from. Looking in the build logs we see it pulls docker run -it --entrypoint /bin/sh gcr.io/oss-fuzz-base/base-builder-go@sha256:c7f01a616db0fc554d98edbd7d49a7177197f77fd4e1371bcb7774d7eac8216d
/root/.go/bin/go version
go version go1.19 linux/amd64 There is a newer image for this which bundles with go1.22: docker run -it --entrypoint /bin/sh gcr.io/oss-fuzz-base/base-builder-go@sha256:37d560af1d31ae8d339902acaedb8eb6fdf3f04469706f39e3bbea44fa3fdeec
/root/.go/bin/go version
go version go1.22.1 linux/amd64 If we can get this to pull the later container for |
Does the following changes in
|
Oh my bad, the container base image is defined in our repo. |
Updated lint and vuln checks to pin to the version in go.mod file.