Add tighter-scoped function types in /client #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
client_more_specific_fetch_interfaces_playground
branch
from
f67d27d
to
6aefffa
Compare
mhutchinson
reviewed
Nov 7, 2024
AlCutter
force-pushed
the
client_more_specific_fetch_interfaces_playground
branch
from
d91000d
to
24e30e6
Compare
AlCutter
force-pushed
the
client_more_specific_fetch_interfaces_playground
branch
from
97b8537
to
ff459f1
Compare
mhutchinson
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the
clientpackage to use tighter scoped functions for fetching different types of log artifact, as opposed to the more generic "fetchURL" approach it previously took.These tighter function signatures match the ones in #281, allowing personality authors to directly use storage instances when e.g. building off-line proof bundles etc.
#278