Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose already set values when initialized is triggered again #26

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

trappitsch
Copy link
Owner

When user triggers initialization a second time (on an already existing box project), the defaults are now selected such that they represent the previous defaults. This allows for faster re-initalization, where the user only has to change the value that should be changed.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 96.36364% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.92%. Comparing base (c95decb) to head (00c85c3).

Files Patch % Lines
src/box/initialization.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   98.78%   98.92%   +0.13%     
==========================================
  Files          19       19              
  Lines        1072     1118      +46     
==========================================
+ Hits         1059     1106      +47     
+ Misses         13       12       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trappitsch trappitsch merged commit 68f4513 into main Mar 22, 2024
9 checks passed
@trappitsch trappitsch deleted the propose_already_set_values_on_reinit branch March 22, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants