Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup dialyzer #243

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

riccardomanfrin
Copy link

Ciao,

I'm trying to use the library but it's giving me dialyzer problems.. would be nice to keep using your repo.

let me know
Thanks

@riccardomanfrin riccardomanfrin requested a review from a team as a code owner September 26, 2024 07:46
Copy link
Contributor

@vkatsuba vkatsuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add call of dialyzer to CI? Maybe it also will be need to update a specs for dialyzer in rebar config file - for better check.

@vkatsuba
Copy link
Contributor

Also you can run CI in your fork workflow - after updates - please, provide a link to CI status.

@riccardomanfrin
Copy link
Author

WOrking on it.. the fixes I did are limited to the code I use, and bring down from 101 to 89 dialyzer warnings afaik.. I'm adding a CI check to verify no one adds more to it at least.. since I can't fix all 89 atm :)

@riccardomanfrin
Copy link
Author

https://github.com/riccardomanfrin/eradius/actions/runs/11052468755

This is the link to the CI run, I added dialyzer check step, and allowed for the current existing warnings to pass which in github CI are 103.

Let me know it it works for you

@vkatsuba
Copy link
Contributor

@0xAX, @RoadRunnr, @ebengt could you please take a look to those changes?

Copy link

@ebengt ebengt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants